readme and login fix - #6
Merged
Merged
Conversation
alex-struk
added a commit
that referenced
this pull request
Jun 23, 2026
…om history, sandbox-escape tests Review findings #3, #4, #5, #6, #7 (PR 6 — dynamic nodes / Deno sandbox), plus #13: - #3: pass --no-remote to deno check + run so static remote imports can't bypass the --allow-net allowlist at module-load time (verified no template uses them). - #4 (cross-cutting): remove the caller x-api-key from the entire workflow/activity input chain (GraphWorkflowInput, ExecutionState, dyn.run input); the platform key is now sourced server-side in the activity from PLATFORM_API_KEY (env added to the temporal-worker manifests). SECURITY: it is no longer persisted in Temporal history. Semantic change: dyn.run callbacks now act as a service account, not the caller. Also resolves #2 (upload-and-Try is now symmetric with /runs). - #5: add sandbox-escape negative tests (read/write/subprocess/ffi/non-allowlisted fetch/remote import). They require the deno-runner up in CI to actually execute. - #6: scope the egress NetworkPolicy DNS rule to the openshift-dns namespace. - #7: dedicated local docker network + documented local-dev egress gap. - #13 (PR 4): collectOutputTopLevelKeys uses the namespace-aware getCtxRootKey, so doc.*/segment.* outputs are snapshotted and restored from cache correctly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.