Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
244 commits
Select commit Hold shift + click to select a range
44795aa
Check for OATS schema before running migration
trslater Dec 20, 2024
bcbaf52
Merge pull request #2043 from bcgov/feature/ALCS-1949-migration-fix
trslater Dec 20, 2024
f7953c0
add tags to commissioner view on ALCS
Abradat Dec 31, 2024
dcb5664
fix commissioner access to tags
Abradat Dec 31, 2024
fc9ef91
add application status pill to commissioner view
Abradat Dec 31, 2024
f6bf2ec
remove unused input file tag service
Abradat Jan 6, 2025
8d8bcab
Merge pull request #2045 from bcgov/feature/ALCS-2351
Abradat Jan 6, 2025
83da74e
ALCS-2453 Handle unique descriptions on condition types
fbarreta Jan 6, 2025
ad16834
Merge pull request #2047 from bcgov/hotfix/ALCS-2453-handle-unique-de…
fbarreta Jan 6, 2025
33d17d6
Merge pull request #2042 from bcgov/hotfix/ALCS-2450
trslater Dec 20, 2024
47566b7
fix portal status and file type dropdown bugs
Abradat Jan 7, 2025
eedaa74
ALCS-2451 Allow to remove check box if the value is zero
fbarreta Jan 6, 2025
3a53525
Merge pull request #2049 from bcgov/bugfix/ALCS-2176
Abradat Jan 7, 2025
1d91eec
Merge pull request #2050 from bcgov/hotfix/ALCS-2451-check-zero-on-ad…
fbarreta Jan 7, 2025
71f0f9d
Merge branch 'develop' into feature/ALCS-2059-decision-view-summary
fbarreta Jan 7, 2025
1665cdf
add db migrations for application conditions board
Abradat Jan 10, 2025
33a594d
add application decision condition card
Abradat Jan 10, 2025
7910210
add internal error exception
Abradat Jan 10, 2025
745b307
add application decision condition card mappings
Abradat Jan 10, 2025
5f251f0
add application decision condition card to module
Abradat Jan 10, 2025
1cfcf41
add application decision condition card support
Abradat Jan 10, 2025
ab04551
add mapper
Abradat Jan 10, 2025
a3d96d4
fix mapping
Abradat Jan 10, 2025
9cb3589
fix mapping
Abradat Jan 10, 2025
8fce040
remove log
Abradat Jan 13, 2025
2ee1c44
add application decision condition card to decision conditions page
Abradat Jan 13, 2025
aa6f59e
ALCS-2059 Create summary
fbarreta Jan 13, 2025
83c8532
Merge pull request #2051 from bcgov/feature/ALCS-2059-decision-view-s…
fbarreta Jan 14, 2025
a7d8bba
ALCS-2426 Navigate to conditions when decision released
fbarreta Jan 14, 2025
41cd24e
Merge pull request #2052 from bcgov/feature/ALCS-2426-update-nav-on-d…
fbarreta Jan 14, 2025
f17d84c
ALCS-2467 Check decisions
fbarreta Jan 14, 2025
0f7921f
Merge pull request #2054 from bcgov/hotfix/ALCS-2467-check-decision-o…
fbarreta Jan 14, 2025
b7a51ad
Update backend document service to check for virus scan failures
trslater Jan 2, 2025
040b100
Fix small file name resolution error
trslater Jan 2, 2025
c0771f3
Fix inquiry document service typo
trslater Jan 3, 2025
d6e38de
Move app decision doc upload dialog to shared component
trslater Jan 6, 2025
33aa818
Create shared interface for decision services
trslater Jan 7, 2025
2ee5e5c
Accept any decision service in shared upload dialog
trslater Jan 7, 2025
3cabbb2
Use shared upload component and pass in decision service for PR's and…
trslater Jan 7, 2025
5626bff
Add missed interface and fix reference
trslater Jan 7, 2025
6e6d5be
Clean up unused NOI/PR dialogs
trslater Jan 7, 2025
3aee92a
Update shared upload dialog for use in apps documents and use there
trslater Jan 7, 2025
5f7d979
Clean up more unused dialogs
trslater Jan 7, 2025
af00a17
Use shared upload dialog in inquiries
trslater Jan 7, 2025
f0d61cb
Use shared upload dialog on notifications
trslater Jan 8, 2025
9c39dbe
Switch PR's to use shared upload dialog
trslater Jan 8, 2025
85a9acc
Switch to shared upload dialog for NOI's
trslater Jan 8, 2025
aefbeaa
Handle scan fail error separately from infected error
trslater Jan 8, 2025
044c42c
Make visibility flags configurable for shared upload dialogs
trslater Jan 9, 2025
9723c76
Allow configuring auto-visibility when selecting type
trslater Jan 9, 2025
648f5e3
Update shared portal uploader to handle separate virus errors
trslater Jan 9, 2025
3572c38
Add server error flag to all portal components with upload and pass i…
trslater Jan 9, 2025
ffeccc1
Strip error-handling and toasts from frontend services
trslater Jan 13, 2025
e59bfa9
Make sure all upload components have toasts
trslater Jan 13, 2025
e22051a
Allow setting name property on API exceptions
trslater Jan 14, 2025
4965f19
Set name for ClamAV errors
trslater Jan 14, 2025
a8de496
For files step, just re-throw errors
trslater Jan 14, 2025
c509b6b
Update all portal instances
trslater Jan 14, 2025
14e2ed2
Fix missing doc type -> vis map keys throwing error
trslater Jan 14, 2025
ee8f2fc
Remove unneeded unknown error text
trslater Jan 14, 2025
a7af049
Remove smiley
trslater Jan 14, 2025
cebe693
Make tests pass
trslater Jan 14, 2025
864e291
Merge pull request #2055 from bcgov/bugfix/ALCS-2370
trslater Jan 15, 2025
d54b942
Allow all but commissioner to archive cards
trslater Jan 15, 2025
25f34ae
Merge pull request #2056 from bcgov/feature/ALCS-2321
trslater Jan 15, 2025
de26f0a
ALCS-2059 QA fixes
fbarreta Jan 15, 2025
0e65c1e
Merge pull request #2057 from bcgov/feature/ALCS-2059-qa-fixes
fbarreta Jan 15, 2025
14345d6
ALCS-2426 Added navigation according to status on search
fbarreta Jan 16, 2025
eacade6
Merge pull request #2058 from bcgov/feature/ALCS-2426-update-nav-on-s…
fbarreta Jan 16, 2025
b8bd077
remove unused import
Abradat Jan 16, 2025
21c7c58
update condition status
Abradat Jan 16, 2025
ecc89ad
update condition card dto, service, and controller
Abradat Jan 16, 2025
674c9f5
add status to decision condition DTO and update API
Abradat Jan 16, 2025
aae2573
update decision condition card service and DTO
Abradat Jan 16, 2025
43a7d78
add optional query parameter for condition status
Abradat Jan 16, 2025
b603350
add application decision condition card to board
Abradat Jan 16, 2025
58d43cc
add application decision condition card dialog component
Abradat Jan 16, 2025
b9f2097
ALCS-2059 Ui Fixes
fbarreta Jan 16, 2025
ed1a8b4
add recon and modification to DTO and API
Abradat Jan 17, 2025
6a8946f
fix decision
Abradat Jan 17, 2025
f418ce5
add tests
Abradat Jan 17, 2025
6723a51
update application decision condition card dialog
Abradat Jan 17, 2025
ff9e4cd
Merge branch 'develop' into feature/ALCS-1871
Abradat Jan 17, 2025
fff57c2
Merge pull request #2059 from bcgov/feature/ALCS-2059-qa-ui-fixes
fbarreta Jan 17, 2025
c73e2bb
ALCS-2474 Fix single date updates
fbarreta Jan 17, 2025
0d14a89
Merge pull request #2062 from bcgov/hotfix/ALCS-2474-fix-single-date-…
fbarreta Jan 17, 2025
9e105d9
ALCS-2447 Change icon color
fbarreta Jan 17, 2025
4a6f086
ALCS-2059 Alignment fix
fbarreta Jan 17, 2025
50bcb05
Merge pull request #2061 from bcgov/feature/ALCS-1871
Abradat Jan 20, 2025
7f9d308
Merge pull request #2064 from bcgov/feature/ALCS-2059-alignment-fix
fbarreta Jan 20, 2025
8ea28bf
Merge pull request #2063 from bcgov/feature/ALCS-2447-fix-conditions-…
fbarreta Jan 20, 2025
775f9f8
ALCS-2360 Migration and label fixes
fbarreta Jan 20, 2025
a76fb28
Merge pull request #2065 from bcgov/bugfix/ALCS-2360-fix-label-typos
fbarreta Jan 20, 2025
3956bb0
Add application decision condition card new API and decision service
Abradat Jan 20, 2025
17d5b42
update application decision condition card and APPCON board card
Abradat Jan 20, 2025
8536bbe
Add and fix tests
Abradat Jan 20, 2025
abcca42
ALCS-2319 Remove card relationship on archive
fbarreta Jan 21, 2025
4764972
ALCS-2319 Fix tests
fbarreta Jan 21, 2025
857d7a5
Merge pull request #2067 from bcgov/feature/ALCS-2319-remove-conditio…
fbarreta Jan 21, 2025
acec672
Merge pull request #2066 from bcgov/feature/ALCS-1871-2
Abradat Jan 21, 2025
bdf0285
fix application condition cards drag and drop not working
Abradat Jan 21, 2025
dfd0f66
ALCS-2478 Allow to add a new date on conditions component
fbarreta Jan 21, 2025
7192c5d
Merge pull request #2070 from bcgov/hotfix/ALCS-2478-add-new-date-on-…
fbarreta Jan 21, 2025
3fb3783
Add sort to conditions by created date
Abradat Jan 21, 2025
c7b9d2c
Fix application decision condition board card bugs
Abradat Jan 21, 2025
da77acd
Merge pull request #2072 from bcgov/feature/ALCS-1871-3
Abradat Jan 21, 2025
c7a735c
Fix displaying wrong Due date for multiple empty dates
Abradat Jan 22, 2025
5bfc745
Merge pull request #2073 from bcgov/feature/ALCS-1871-4
Abradat Jan 22, 2025
e786cf4
soft remove decision condition cards on decision removal
Abradat Jan 22, 2025
ce59d89
Merge pull request #2074 from bcgov/feautre/ALCS-1871-4
Abradat Jan 22, 2025
91940e0
Merge branch 'develop' into backport
trslater Jan 22, 2025
a185a89
Merge pull request #2076 from bcgov/backport
trslater Jan 22, 2025
e520ae4
Set up flag backend
trslater Jan 21, 2025
887771f
Fix: explicitly check for undefined/null when formatting date
trslater Jan 21, 2025
ce5c989
Update DB
trslater Jan 21, 2025
293d580
Update frontend DTO's with new data from backend
trslater Jan 21, 2025
58376ad
Create shared decision flag dialog
trslater Jan 21, 2025
279555a
Update decision view with flag button, dialog, and details section
trslater Jan 21, 2025
50aff3d
Update backend to send decision flag status to cards
trslater Jan 21, 2025
46af33c
Add icon asset missed in earlier commit
trslater Jan 21, 2025
3959a5b
ALCS-2478 Created Script
fbarreta Jan 22, 2025
95a6809
Conditionally show flag on condition cards
trslater Jan 21, 2025
1dd18a8
Add flag icon to card dialog
trslater Jan 21, 2025
68bc49b
Fix unflag dialog
trslater Jan 21, 2025
cef6116
Merge pull request #2078 from bcgov/hotfix/ALCS-2478-add-date-to-sing…
fbarreta Jan 22, 2025
d7016d8
Improve handling of flag button on smaller screens
trslater Jan 22, 2025
245272f
Fix tests
trslater Jan 23, 2025
d78553a
Merge pull request #2079 from bcgov/feature/ALCS-2226
trslater Jan 23, 2025
95aac2e
Align revert button to right like edit button
trslater Jan 23, 2025
d470797
Merge pull request #2083 from bcgov/feature/ALCS-2226-QA-1
trslater Jan 23, 2025
8658dc9
2226 QA #2: Apply draft button fix to NOI's
trslater Jan 23, 2025
bd38acc
Merge pull request #2085 from bcgov/feature/ALCS-2226-QA-2
trslater Jan 23, 2025
cbc667d
Add archive and unarchive features to application decision condition …
Abradat Jan 23, 2025
f2c55c5
Merge branch 'develop' into feature/ALCS-2319-2
Abradat Jan 23, 2025
50c0c1e
Remove unnecessary logging
Abradat Jan 23, 2025
38e89dd
Merge branch 'feature/ALCS-2319-2' of https://github.com/bcgov/alcs i…
Abradat Jan 23, 2025
611ea62
Merge pull request #2086 from bcgov/feature/ALCS-2319-2
Abradat Jan 23, 2025
0d3a9eb
Change condition index from letter to number
Abradat Jan 23, 2025
6d50ee1
ALCS-2478 Create new dates when duplicating conditions
fbarreta Jan 23, 2025
e5453ec
Merge pull request #2087 from bcgov/feature/ALCS-2484
Abradat Jan 23, 2025
91b6153
Merge pull request #2088 from bcgov/hotfix/ALCS-2487-create-new-dates…
fbarreta Jan 23, 2025
65a0c11
Add feature to enable moving application condition cards to other boards
Abradat Jan 24, 2025
fa99681
Display and hide pills when moving condition cards between boards
Abradat Jan 24, 2025
78e1099
Reload condition card when moved to another board
Abradat Jan 25, 2025
a86055d
Merge pull request #2089 from bcgov/feature/ALCS-2406
Abradat Jan 25, 2025
39b1c05
Merge branch 'develop' into backport/2025-01-28
Abradat Jan 28, 2025
06c0710
Merge pull request #2091 from bcgov/backport/2025-01-28
Abradat Jan 28, 2025
12849d2
Fix multiple condition status pills misalignment on card
Abradat Jan 28, 2025
faaa3bb
Fix public doc sorting
trslater Jan 28, 2025
4c1bd92
Merge pull request #2092 from bcgov/bugfix/ALCS-2448
trslater Jan 28, 2025
87125ef
Apply public search sorting fix to NOI's
trslater Jan 29, 2025
093f8a5
Merge pull request #2093 from bcgov/bugfix/ALCS-2448-NOIs
trslater Jan 29, 2025
1821629
add condition cards to commissioner schedule board meetings
Abradat Jan 29, 2025
f0b45b6
Remove application card type support from application conditions board
Abradat Jan 30, 2025
53c9e6e
ALCS-2081 Added condition cards on homepage
fbarreta Jan 30, 2025
99b0f7c
ALCS-2081 Home controller test fix
fbarreta Jan 30, 2025
cbca94f
ALCS-2081 Frontend test fixes
fbarreta Jan 30, 2025
0d9c73a
Add NOI Condition Cards
Abradat Jan 31, 2025
b687c44
Fix modification service not being injected
Abradat Jan 31, 2025
25f8911
ALCS-2468 Delete dependencies
fbarreta Jan 31, 2025
290318f
ALCS-2468 Delete dependencies
fbarreta Jan 31, 2025
4fb42ce
ALCS-2468 Fix tests
fbarreta Jan 31, 2025
2191b1f
Merge pull request #2097 from bcgov/feature/ALCS-2044-2501
trslater Jan 31, 2025
6eeb1e4
Merge branch 'develop' into feature/ALCS-2468-delete-decisions-relations
fbarreta Jan 31, 2025
1b82e2f
Throw error if correct documents failed to generate and attach
trslater Jan 31, 2025
29f3d65
ALCS-2468 Hard delete dates
fbarreta Jan 31, 2025
322fba2
ALCS-2468 Fix tests
fbarreta Jan 31, 2025
616366e
ALCS-2468 Fix test
fbarreta Jan 31, 2025
799362d
Fix failing tests
trslater Feb 1, 2025
e35e1fb
Merge pull request #2099 from bcgov/feature/ALCS-2411
trslater Feb 3, 2025
17b0780
ALCS-2468 Application fixes
fbarreta Feb 3, 2025
ed7d45f
ALCS-2468 Align Applications and NOIs
fbarreta Feb 3, 2025
54a9748
ALCS-2468 Fix test
fbarreta Feb 3, 2025
243838a
Merge pull request #2098 from bcgov/feature/ALCS-2468-delete-decision…
fbarreta Feb 3, 2025
2b4fd97
ALCS-2081 Dtos Refactor
fbarreta Feb 4, 2025
123519c
Merge branch 'develop' into feature/ALCS-2081-condition-cards-on-home…
fbarreta Feb 4, 2025
373b7d9
Fix name
Abradat Feb 4, 2025
d4af5a8
ALCS-2081 Fix merge error
fbarreta Feb 4, 2025
470eea2
ALCS-2081 Other merge conflict fix
fbarreta Feb 4, 2025
831d4b3
Add NOI Condition Card
Abradat Feb 4, 2025
fc2ed34
ALCS-2081 New DTOs cleanup
fbarreta Feb 4, 2025
83dd6fb
ALCS-2081 Added missing service to test
fbarreta Feb 4, 2025
2284ac8
ALCS-2081 Last test fix
fbarreta Feb 4, 2025
f3bd323
ALCS-2081 Property cleanup
fbarreta Feb 4, 2025
ab4bcc1
ALCS-2081 Unused import removal
fbarreta Feb 4, 2025
01418e9
Always redirect to frontend after login
trslater Feb 4, 2025
cbcf505
Toast on login when query param present
trslater Feb 4, 2025
2bd931d
Merge pull request #2094 from bcgov/feature/ALCS-2406-2
Abradat Feb 4, 2025
28e7625
Merge pull request #2095 from bcgov/feature/ALCS-2081-condition-cards…
fbarreta Feb 4, 2025
9bf3c47
Merge pull request #2101 from bcgov/feature/ALCS-2044-2502
Abradat Feb 4, 2025
f57f0b3
Fix tests
trslater Feb 4, 2025
25c1f3e
Merge pull request #2103 from bcgov/hotfix/ALCS-2509
trslater Feb 4, 2025
34f9e69
fix: exclude application condition cards with deleted decisions from …
Abradat Feb 4, 2025
bde33d6
add archiving and unarchiving feature to notice of intent condition c…
Abradat Feb 4, 2025
60b75dd
Merge pull request #2104 from bcgov/feature/ALCS-2044-2503
Abradat Feb 5, 2025
8887d47
ALCS-2570 New component for unflag dialog
fbarreta Feb 5, 2025
c8c03a7
ACLS-2507 Fix imports
fbarreta Feb 5, 2025
ae2d83c
Generate SRW PDF before submitting
trslater Feb 5, 2025
f74d228
Merge pull request #2105 from bcgov/feature/ACLS-2507-format-flag-modals
fbarreta Feb 5, 2025
ba90a2c
Merge pull request #2106 from bcgov/feature/ALCS-2411-QA-1
trslater Feb 5, 2025
0095991
ALCS-2507 Show warning also on edit
fbarreta Feb 5, 2025
849d380
Merge pull request #2107 from bcgov/ALCS-2507-qa-fix
fbarreta Feb 5, 2025
ae09e0e
ALCS-2468 Fix delete with cards
fbarreta Feb 5, 2025
cb3a6c5
Merge pull request #2108 from bcgov/feature/ALCS-2468-fix-delete-with…
fbarreta Feb 5, 2025
c771bf5
ALCS-2468 Clear conditions array
fbarreta Feb 6, 2025
91afba8
Merge pull request #2109 from bcgov/feature/ALCS-2468-clear-condition…
fbarreta Feb 6, 2025
a09e9d2
Fix documents duplicating on replace file
trslater Feb 5, 2025
dea25e2
Filter file documents missing document fields
trslater Feb 6, 2025
6502052
Fix tests
trslater Feb 6, 2025
ccbe064
Create single date if single date and missing
trslater Feb 6, 2025
c6b5f87
Fix runtime errors from missing decision
trslater Feb 6, 2025
2afbc80
Fix condition card display issue when date missing
trslater Feb 6, 2025
fc697b9
Merge pull request #2111 from bcgov/bugfix/ALCS-2523
trslater Feb 6, 2025
46c0a63
ALCS-2468 Remove the individual date method
fbarreta Feb 6, 2025
e176955
Merge pull request #2110 from bcgov/feature/ALCS-2495
trslater Feb 6, 2025
1413b76
Merge pull request #2112 from bcgov/feature/ALCS-2468-condition-delet…
fbarreta Feb 7, 2025
5ce7310
Make file edit configurable by doc type
trslater Feb 11, 2025
9429ff0
Fix inquiries' documents not editable
trslater Feb 11, 2025
9c1e9e1
Update doc type after editing documents
trslater Feb 11, 2025
9a852cc
ALCS-2081 Added pills, and reduce by card id
fbarreta Feb 11, 2025
a7a6f98
ALCS-2081 Remove unnecessary code
fbarreta Feb 11, 2025
60e9025
ALCS-2081 Fix tests
fbarreta Feb 11, 2025
5e208df
ALCS-2081 Remove unused service
fbarreta Feb 11, 2025
a9d6e9d
Merge pull request #2117 from bcgov/bugfix/ALCS-2529
trslater Feb 11, 2025
dd2ec58
ALCS-2081 Review fixes
fbarreta Feb 11, 2025
7da857a
Merge pull request #2118 from bcgov/feature/ALCS-2081-recon-modi-check
fbarreta Feb 11, 2025
5724d3e
Improve documents tables
trslater Feb 11, 2025
1b0755b
Merge pull request #2119 from bcgov/feature/ALCS-2440
trslater Feb 11, 2025
c1e2715
ALCS-2504 Nois Home Page cards implementation
fbarreta Feb 11, 2025
4704323
ALCS-2504 Fix service test
fbarreta Feb 11, 2025
98feb50
ALCS-2504 Fixed controller and frontend tests
fbarreta Feb 11, 2025
7a193f7
ALCS-2504 Added automapper to service test
fbarreta Feb 11, 2025
efb3d24
ALCS-2514: Fix dockerfile warnings
dylanrogowsky-oxd Feb 12, 2025
3c18994
ALCS-2504 Fix time map
fbarreta Feb 12, 2025
dfb5a35
Merge pull request #2120 from bcgov/feature/ALCS-2504-noi-cards-home-…
fbarreta Feb 12, 2025
df366c6
ALCS-2081 Added condition subtasks cards
fbarreta Feb 12, 2025
9122111
ALCS-2081 Fix test
fbarreta Feb 12, 2025
b682059
Merge pull request #2123 from bcgov/feature/ALCS-2081-add-condition-s…
fbarreta Feb 12, 2025
4394f65
ALCS-2081 Implemented subtasks pills
fbarreta Feb 13, 2025
4d7cebd
ACLS-2081 Test fixes
fbarreta Feb 13, 2025
a6f9502
Merge pull request #2124 from bcgov/feature/ALCS-2081-add-condition-s…
fbarreta Feb 13, 2025
dd78243
ALCS-2081 Remove active days for conditions and conditions subtasks
fbarreta Feb 13, 2025
b41af96
Merge pull request #2125 from bcgov/feature/ALCS-2081-add-condition-s…
fbarreta Feb 13, 2025
ca5fba9
Merge pull request #2122 from bcgov/feature/ALCS-2514-fix-dockerfile-…
dylanrogowsky-oxd Feb 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions alcs-frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# Copy the source code to the /app directory
COPY . .

ENV NODE_OPTIONS="--max-old-space-size=2048"
ENV NODE_OPTIONS "--max-old-space-size=2048"

Check warning on line 16 in alcs-frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / build / build-frontend / build

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Build the application
RUN npm run build -- --output-path=dist --output-hashing=all
Expand Down Expand Up @@ -47,10 +47,10 @@
RUN chmod -R go+rwx /usr/share/nginx/html/assets

# provide dynamic scp content-src
ENV ENABLED_CONNECT_SRC=" 'self' http://localhost:* nrs.objectstore.gov.bc.ca"
ENV ENABLED_CONNECT_SRC " 'self' http://localhost:* nrs.objectstore.gov.bc.ca"

Check warning on line 50 in alcs-frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / build / build-frontend / build

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# set to true to enable maintenance mode
ENV MAINTENANCE_MODE="false"
ENV MAINTENANCE_MODE "false"

Check warning on line 53 in alcs-frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / build / build-frontend / build

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# When the container starts, replace the settings.json with values from environment variables
ENTRYPOINT [ "./init.sh" ]
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
UnarchiveCardService,
} from '../../../services/unarchive-card/unarchive-card.service';
import { ConfirmationDialogService } from '../../../shared/confirmation-dialog/confirmation-dialog.service';
import { CardType } from '../../../shared/card/card.component';

@Component({
selector: 'app-unarchive',
Expand All @@ -18,7 +19,7 @@ export class UnarchiveComponent {

constructor(
private unarchiveCardService: UnarchiveCardService,
private confirmationDialogService: ConfirmationDialogService
private confirmationDialogService: ConfirmationDialogService,
) {}

onUnarchive(uuid: string) {
Expand All @@ -36,6 +37,11 @@ export class UnarchiveComponent {
async onSearch() {
const results = await this.unarchiveCardService.search(this.search);
if (results) {
results.forEach((result) => {
if (result.type === CardType.APP_CON || result.type === CardType.NOI_CON) {
result.type = 'Condition';
}
});
this.cards = results;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
[application]="application"
[modifications]="modifications"
[reconsiderations]="reconsiderations"
[conditionCards]="decisionConditionCards"
[showStatus]="true"
[submissionStatusService]="applicationStatusService"
[applicationDetailService]="applicationDetailService"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { ApplicationSubmissionService } from '../../services/application/applica
import { ApplicationSubmissionStatusService } from '../../services/application/application-submission-status/application-submission-status.service';

import { ApplicationComponent } from './application.component';
import { ApplicationDecisionConditionCardService } from '../../services/application/decision/application-decision-v2/application-decision-condition/application-decision-condition-card/application-decision-condition-card.service';

describe('ApplicationComponent', () => {
let component: ApplicationComponent;
Expand All @@ -25,6 +26,7 @@ describe('ApplicationComponent', () => {
let mockReviewService: DeepMocked<ApplicationReviewService>;
let mockAppSubmissionService: DeepMocked<ApplicationSubmissionService>;
let mockAppStatusService: DeepMocked<ApplicationSubmissionStatusService>;
let mockApplicationDecisionConditionCardService: DeepMocked<ApplicationDecisionConditionCardService>;

beforeEach(async () => {
mockAppDetailService = createMock();
Expand All @@ -40,6 +42,8 @@ describe('ApplicationComponent', () => {
mockAppSubmissionService = createMock();
mockAppStatusService = createMock();

mockApplicationDecisionConditionCardService = createMock();

await TestBed.configureTestingModule({
providers: [
{
Expand Down Expand Up @@ -70,6 +74,10 @@ describe('ApplicationComponent', () => {
provide: ApplicationSubmissionStatusService,
useValue: mockAppStatusService,
},
{
provide: ApplicationDecisionConditionCardService,
useValue: mockApplicationDecisionConditionCardService,
},
{
provide: ActivatedRoute,
useValue: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ import { ReviewComponent } from './review/review.component';
import { ApplicationSubmissionStatusService } from '../../services/application/application-submission-status/application-submission-status.service';
import { ApplicationTagService } from '../../services/application/application-tag/application-tag.service';
import { FileTagService } from '../../services/common/file-tag.service';
import { ApplicationDecisionV2Service } from '../../services/application/decision/application-decision-v2/application-decision-v2.service';
import { ApplicationDecisionConditionCardDto } from '../../services/application/decision/application-decision-v2/application-decision-v2.dto';
import { ApplicationDecisionConditionCardService } from '../../services/application/decision/application-decision-v2/application-decision-condition/application-decision-condition-card/application-decision-condition-card.service';

export const unsubmittedRoutes = [
{
Expand Down Expand Up @@ -184,6 +187,7 @@ export class ApplicationComponent implements OnInit, OnDestroy {
application: ApplicationDto | undefined;
reconsiderations: ApplicationReconsiderationDto[] = [];
modifications: ApplicationModificationDto[] = [];
decisionConditionCards: ApplicationDecisionConditionCardDto[] = [];
submission?: ApplicationSubmissionDto;

isApplicantSubmission = false;
Expand All @@ -195,6 +199,7 @@ export class ApplicationComponent implements OnInit, OnDestroy {
public applicationSubmissionService: ApplicationSubmissionService,
private reconsiderationService: ApplicationReconsiderationService,
private modificationService: ApplicationModificationService,
private decisionConditionCardService: ApplicationDecisionConditionCardService,
private route: ActivatedRoute,
private titleService: Title,
public applicationStatusService: ApplicationSubmissionStatusService,
Expand All @@ -214,6 +219,9 @@ export class ApplicationComponent implements OnInit, OnDestroy {
this.reconsiderationService.fetchByApplication(application.fileNumber);
this.modificationService.fetchByApplication(application.fileNumber);

this.decisionConditionCards =
(await this.decisionConditionCardService.fetchByApplicationFileNumber(application.fileNumber)) || [];

this.isApplicantSubmission = application.source !== SYSTEM_SOURCE_TYPES.ALCS;
let wasSubmittedToLfng = false;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { appChildRoutes, ApplicationComponent } from './application.component';
import { BoundaryAmendmentComponent } from './boundary-amendment/boundary-amendment.component';
import { EditBoundaryAmendmentDialogComponent } from './boundary-amendment/edit-boundary-amendment-dialog/edit-boundary-amendment-dialog.component';
import { DecisionModule } from './decision/decision.module';
import { DocumentUploadDialogComponent } from './documents/document-upload-dialog/document-upload-dialog.component';
import { DocumentsComponent } from './documents/documents.component';
import { InfoRequestsComponent } from './info-requests/info-requests.component';
import { InfoRequestDialogComponent } from './info-requests/info-request-dialog/info-request-dialog.component';
Expand Down Expand Up @@ -73,7 +72,6 @@ const routes: Routes = [
ApplicantInfoComponent,
LfngInfoComponent,
DocumentsComponent,
DocumentUploadDialogComponent,
ProposalComponent,
NfuProposalComponent,
SubdProposalComponent,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
<div class="container">
<div class="section">
<h3>Create New Condition Card</h3>
</div>
<div class="section">
<ng-select
class="card-type"
appearance="outline"
[items]="conditionBoard?.statuses!"
placeholder="Workflow Stage*"
bindLabel="label"
bindValue="statusCode"
[clearable]="false"
[(ngModel)]="selectedStatus"
(change)="onStatusSelected($event)"
>
<ng-template ng-option-tmp let-item="item">
<span [innerHTML]="item.label"> </span>
</ng-template>
<ng-template ng-label-tmp let-item="item">
<span [innerHTML]="item.label"> </span>
</ng-template>
</ng-select>
</div>
<div class="section">
<span>Add one or more conditions*</span>
<div class="table-container">
<table mat-table class="conditions-table mat-elevation-z3" [dataSource]="dataSource" style="width: 100%">
<ng-container matColumnDef="select">
<th mat-header-cell *matHeaderCellDef class="column-select"></th>
<td mat-cell *matCellDef="let element" class="column-select">
<mat-checkbox [(ngModel)]="element.selected" [disabled]="isConditionCardNotNull(element)"></mat-checkbox>
</td>
</ng-container>

<ng-container matColumnDef="index">
<th mat-header-cell *matHeaderCellDef class="column-index">#</th>
<td mat-cell *matCellDef="let element" class="column-index">{{ element.index }}</td>
</ng-container>

<ng-container matColumnDef="type">
<th mat-header-cell *matHeaderCellDef class="column-type">Type</th>
<td mat-cell *matCellDef="let element" class="column-type">{{ element.condition.type.label }}</td>
</ng-container>

<ng-container matColumnDef="description">
<th mat-header-cell *matHeaderCellDef class="column-description">Description</th>
<td mat-cell *matCellDef="let element" class="column-description">{{ element.condition.description }}</td>
</ng-container>

<tr mat-header-row *matHeaderRowDef="displayColumns"></tr>
<tr
mat-row
*matRowDef="let row; columns: displayColumns"
[class.disabled-row]="isConditionCardNotNull(row)"
matTooltip="Condition is already used by another card"
[matTooltipDisabled]="!isConditionCardNotNull(row)"
></tr>
</table>
</div>
</div>
<div class="section">
<div class="button-row">
<button type="button" mat-stroked-button color="primary" (click)="onCancel()">Cancel</button>
<button type="button" mat-flat-button color="primary" [disabled]="isSaveDisabled()" (click)="onSave()">
Save
</button>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
@use '../../../../../../styles/colors.scss' as *;

.container {
display: flex;
flex-direction: column;
width: 100%;
padding: 12px 8px;
overflow-y: hidden;
}

.section {
width: 100%;
padding: 16px;
}

.button-row {
display: flex;
justify-content: flex-end;
gap: 8px;
}

.column-select {
width: 10%;
}

.column-index {
width: 10%;
}

.column-type {
width: 30%;
}

.column-description {
width: 50%;
}

.conditions-table {
margin-top: 16px;
width: 100%;
}

.table-container {
max-height: 300px;
overflow-y: auto;
padding: 2px;
}

.disabled-row {
background-color: #f0f0f0;
opacity: 0.6;
cursor: default;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import { NO_ERRORS_SCHEMA } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { createMock, DeepMocked } from '@golevelup/ts-jest';
import { MatDialogModule, MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
import { MatTableModule } from '@angular/material/table';
import { MatSortModule } from '@angular/material/sort';
import { HttpClientTestingModule } from '@angular/common/http/testing';
import { RouterTestingModule } from '@angular/router/testing';
import { ApplicationDecisionConditionCardService } from '../../../../../services/application/decision/application-decision-v2/application-decision-condition/application-decision-condition-card/application-decision-condition-card.service';
import { BoardService } from '../../../../../services/board/board.service';
import { ToastService } from '../../../../../services/toast/toast.service';
import { ConditionCardDialogComponent } from './condition-card-dialog.component';

describe('ConditionCardDialogComponent', () => {
let component: ConditionCardDialogComponent;
let fixture: ComponentFixture<ConditionCardDialogComponent>;
let mockDecisionConditionCardService: DeepMocked<ApplicationDecisionConditionCardService>;
let mockBoardService: DeepMocked<BoardService>;
let mockToastService: DeepMocked<ToastService>;

beforeEach(async () => {
mockDecisionConditionCardService = createMock();
mockBoardService = createMock();
mockToastService = createMock();

await TestBed.configureTestingModule({
declarations: [ConditionCardDialogComponent],
imports: [
MatDialogModule,
BrowserAnimationsModule,
MatTableModule,
MatSortModule,
HttpClientTestingModule,
RouterTestingModule,
],
providers: [
{ provide: MAT_DIALOG_DATA, useValue: { conditions: [], decision: 'decision-uuid' } },
{ provide: MatDialogRef, useValue: {} },
{ provide: ApplicationDecisionConditionCardService, useValue: mockDecisionConditionCardService },
{ provide: BoardService, useValue: mockBoardService },
{ provide: ToastService, useValue: mockToastService },
],
schemas: [NO_ERRORS_SCHEMA],
}).compileComponents();

fixture = TestBed.createComponent(ConditionCardDialogComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});

it('should create', () => {
expect(component).toBeTruthy();
});
});
Loading