ALCS-2455: Allow editing resolution numbers#2237
Merged
Conversation
Collaborator
trslater
commented
Mar 17, 2025
trslater
commented
- Had to update shared inline number component:
- Add option to hide buttons, so component can be controlled by parent
- Add option to disable thousands separator, since this doesn't make sense for resolution numbers
- Add ability to set async validators
- Use number type internally
- The component used strings, but the internal Angular component used numbers, so the value was changing from string to number while typing
- Make resolution number editable:
- Add inline editing component
- Modify the way decision/pos-decision observables work to avoid flashes of old value
- Add buttons to control inline editing component
- Hack to position error messages
- Created a new backend/frontend services/controller for checking if a resolution number exists
- Add an async validator to check for existing resolution numbers on change
New options for: - Hide buttons (for external control) - Disable thousands separators
- Still use string for input/output - Rationale: inline number component was using string internally, but the Angular input was changing this to a number, so the initial value was a string, but when changed, the number changed to a number
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.