Conversation
trslater
force-pushed
the
2649-security-fixes
branch
from
22f6479 to
ecf9457
Compare
7 tasks
Node 24 doesn't include binaries automatically
This reverts commit 0b31839.
Add it to the right package this time
trslater
commented
Jan 8, 2026
| ################### | ||
|
|
||
| FROM node:20-alpine AS development | ||
| FROM node:24-alpine AS development |
Collaborator
Author
There was a problem hiding this comment.
This image uses a newer version of Alpine, which should patch a lot of the vulnerable binaries.
|
|
|
PaulGreywal
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've gone through all Trivy and dependabot security alerts. Most were NPM fixes. Most of these were fixed by Angular updates or normal dependabot updates. There were a few I needed to update myself. The only non-npm issue was libpng. This should be resolved by the new image being used: node:24-apline. The Node 24 image uses a newer version of Alpine, which should include the patched libpng.
As for ACS, I've upgraded the API Node version to 24 as well. This should fix most issues for the API, but at the time of writing, all Node images had a critical and a few high security vulnerabilities: https://hub.docker.com/_/node/tags