Pull Redis image from Bitnami legacy repo instead#146
Closed
norrisng-bc wants to merge 2 commits into
Closed
Conversation
Bitnami yanked their public Helm chart catalog >:(
norrisng-bc
requested review from
TimCsaky and
jatindersingh93
as code owners
Coverage Report
|
norrisng-bc
force-pushed
the
chore/redis-bitnami-legacy
branch
from
3de8187 to
30bfff3
Compare
Side note: codeclimate-action was bumped to v9 in our other repos before Code Climate shut down their API
norrisng-bc
force-pushed
the
chore/redis-bitnami-legacy
branch
from
30bfff3 to
d2c1463
Compare
TimCsaky
force-pushed
the
master
branch
13 times, most recently
from
08e7aa2 to
68b57eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull the Redis image from the Bitnami legacy repo instead. This is because Bitnami has since yanked their free charts.
Separately, the Codeclimate GitHub Action has also been bumped up to v9. This was already updated in our previous repos (e.g. https://github.com/bcgov/document-generation-showcase/pull/95/files#diff-6e608e02c595d53ab6b70822a2bf19abcfc6ddcc976c2f536ad5bfca20f0443f); without this update, it will fail to run and break the pipeline.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-4078
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
v*.api-spec.yamldocumentation (if appropriate)Further comments