Skip to content

Conversation

@RyanBirtch-aot
Copy link
Contributor

Description

Users acting in a Reviewer capacity need the ability to search through form submissions not only by basic metadata (submitter, status, confirmation ID, etc.) but also by the values contained inside specific form fields. This functionality did not previously exist, forcing reviewers to manually scan submissions or export data to external tools.

This PR introduces a new Advanced Submission Search feature, providing users with more powerful and granular search capabilities within the Submissions Table.

Frontend Enhancements

  • Added AdvancedSubmissionSearch component:
    • Drawer-based UI for entering a search term and selecting specific fields to search within.
    • Emits a structured payload { value, fields } to SubmissionsTable.
    • Supports multi-field selection and removable chips.
  • Integrated the advanced search drawer into SubmissionsTable.vue:
    • New Advanced Search button opens the drawer.
    • Updated handleSearch to support both simple and advanced searches.
  • Improved column handling:
    • When advanced search specifies fields, the table auto-includes those columns temporarily.
    • Integrated with existing user-selected column preferences.

Backend Enhancements

  • Expanded processPaginationData to support new advanced search payload:
    • Recognizes { value, fields } when advanced search is used.
    • Searches only within the allowed fields instead of the full submission record.
  • Added searchSubmissions helper to encapsulate filtering logic.

Type of Change

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@RyanBirtch-aot RyanBirtch-aot marked this pull request as ready for review November 18, 2025 02:32
@nimya-aot
Copy link
Contributor

@RyanBirtch-aot Build failed for this PR. Can you check?

@github-actions

This comment has been minimized.

@nimya-aot
Copy link
Contributor

nimya-aot commented Nov 20, 2025

@RyanBirtch-aot If we have 2 versions for one form, and search for the fields, Result is not showing up.
image

Also after we do an advance search, submission page reset with column having that searched field in the table
image
I think we need to show up only the results with the search field only, not all submissions with that field added to the submission view.

@sonarqubecloud
Copy link

@nimya-aot
Copy link
Contributor

@RyanBirtch-aot Can you deploy this PR again?

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants