Feature/ccp 5048 fix email submission link#1920
Merged
usingtechnology merged 5 commits intoJul 6, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Fixes unauthenticated access to the “View this submission” email link (/form/view?s=<submissionId>) so that a 401 from the permission-check call no longer redirects users to NotFound, enabling the intended login/auth flow instead.
Changes:
- Updated the
FormViewroutebeforeEnterguard to treat401(unauthenticated) differently from404(missing submission). - Preserved
NotFoundredirect behavior for genuine404cases while allowing401cases to proceed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) { | ||
| // Expected errors: redirect to NotFound | ||
| if (err.response?.status === 401) { | ||
| // Not authenticated — let the global auth guard redirect to login |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
ccp-5048
When an unauthenticated user clicks the "View this submission" link from a submission confirmation email, the app navigates to /form/view?s=.
What was broken:
The FormView route's beforeEnter guard calls getSubmissionStatuses() to check permissions. For unauthenticated users, this returns a 401. The guard was treating 401 the same as 404 — redirecting to the NotFound page. So users saw a 404 instead of being asked to log in.
The fix (router.js):
Split the 401 and 404 handling:
Type of Change
Checklist
Further comments