DEP-261: update object storage service to normalize URLs to keys - #2842
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
+ Coverage 74.92% 74.96% +0.04%
==========================================
Files 517 517
Lines 19853 19932 +79
Branches 1612 1715 +103
==========================================
+ Hits 14874 14942 +68
- Misses 4971 4981 +10
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jareth-whitney
approved these changes
Apr 30, 2026
jareth-whitney
left a comment
jareth-whitney
left a comment
Contributor
There was a problem hiding this comment.
Well that's a fancy way to make links - looks good! Just review what you're passing into get_url() on line 96 of test_object_storage_service.py.
| service = ObjectStorageService() | ||
|
|
||
| assert service.get_url('') == '' | ||
| assert service.get_url(None) == '' |
Contributor
There was a problem hiding this comment.
It looks like SonarCloud doesn't like the type that you're passing to get_url here.
| try { | ||
| const savedDocumentDetails = await saveObject(bannerImage, { filename: bannerImage.name }); | ||
| return savedDocumentDetails?.filepath || ''; | ||
| return savedDocumentDetails?.uniquefilename || ''; |
Contributor
There was a problem hiding this comment.
Nice, I prefer this
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: 🎟️ DEP-261
Description of changes:
User Guide update ticket (if applicable):
Common component changes: