Feature/dep271: Updated header/footer links. Updated footer to match BC Gov site. Added layout width to theme. - #2844
Conversation
…BC Gov website. Added layout width to theme.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2844 +/- ##
=======================================
Coverage 75.16% 75.16%
=======================================
Files 517 517
Lines 20055 20056 +1
Branches 1713 1723 +10
=======================================
+ Hits 15074 15075 +1
Misses 4972 4972
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
| }; | ||
|
|
||
| export const LayoutWidth = { | ||
| default: '100%', |
There was a problem hiding this comment.
what is LayoutWidth.default used for?
There was a problem hiding this comment.
Nothing yet, it's aspirational. Usually on a website you'll have a standardized layout width for all pages that have centred content (example 1120px). This is to ensure your centred content/header/footer all align. Certain layouts that aren't centred, such as our admin area, would not use the value (they have a 100% width layout).
An example of this is in WordPress, which has a default constrained width that can be applied to multiple pages/containers.
There was a problem hiding this comment.
Also, for now I just set the container width in the footer to 100%, until we agree on a value for centred content that we can apply to the individual engagement page and homepage. The footer can scale to any container width.
| const baseURL = getBaseUrl(); | ||
| const { t: translate } = useAppTranslation(); | ||
| const isLoggedIn = useAppSelector((state) => state.user.authentication.authenticated); | ||
| const isMediumScreenOrLarger: boolean = useMediaQuery((theme: Theme) => theme.breakpoints.up('md')); |
There was a problem hiding this comment.
I appreciate getting rid of this useMediaQuery usage
3 participants
Issue #: https://citz-gdx.atlassian.net/browse/DEP-271
Description of changes:
User Guide update ticket (if applicable):
Common component changes: