Skip to content

Comments

WFPREV-850 : Generate project list in backend for consistency#1068

Merged
sukhpalp merged 3 commits intomainfrom
WFPREV-850
Jan 9, 2026
Merged

WFPREV-850 : Generate project list in backend for consistency#1068
sukhpalp merged 3 commits intomainfrom
WFPREV-850

Conversation

@sukhpalp
Copy link
Collaborator

@sukhpalp sukhpalp commented Jan 6, 2026

No description provided.

@sukhpalp sukhpalp requested review from dhlevi and ssylver93 January 6, 2026 23:50
dhlevi
dhlevi previously approved these changes Jan 7, 2026
export interface ReportRequest {
reportType: ReportType;
projects: ReportProject[];
projects?: ReportProject[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these ever nullable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the way it works now is that you can pass in either the filters or the specific projects. You don't need both. If you pass both as null the controller logic rejects the call. So one of the two can be null.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, if you pass in both, the projects take priority over the filters because they are more specific.

@sukhpalp sukhpalp merged commit 6029012 into main Jan 9, 2026
5 of 6 checks passed
@sukhpalp sukhpalp deleted the WFPREV-850 branch January 9, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants