WFPREV-905 : Add fiscal_forecast_amount and ancillary_funding_provider to reports#1080
Merged
WFPREV-905 : Add fiscal_forecast_amount and ancillary_funding_provider to reports#1080
Conversation
ssylver93
reviewed
Jan 27, 2026
| p.bc_parks_section_org_unit_id, | ||
| bcps.org_unit_name AS bc_parks_section_org_unit_name, | ||
| p.fire_centre_org_unit_id, | ||
| fc.org_unit_name AS fire_centre_org_unit_name, -- todo does not match data returned by API |
Collaborator
There was a problem hiding this comment.
Is this comment still the case? If not can it be removed?
ssylver93
reviewed
Jan 27, 2026
| p.bc_parks_section_org_unit_id, | ||
| bcps.org_unit_name AS bc_parks_section_org_unit_name, | ||
| p.fire_centre_org_unit_id, | ||
| fc.org_unit_name AS fire_centre_org_unit_name, -- todo does not match |
Collaborator
There was a problem hiding this comment.
Same as above. I think this comment is possibly no longer valid.
ssylver93
previously approved these changes
Jan 27, 2026
Collaborator
ssylver93
left a comment
ssylver93
left a comment
There was a problem hiding this comment.
Looks good. Can you just check that the fire centre org units are being returned correctly as per my comments? I'm pretty sure they were ok when I worked on this last. If so the view script comments can be removed.
sukhpalp
added a commit
that referenced
this pull request
Jan 27, 2026
sukhpalp
added a commit
that referenced
this pull request
Jan 29, 2026
JLeenk
pushed a commit
to JLeenk/nr-bcws-wfprev
that referenced
this pull request
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.