Merged
Conversation
|
dhlevi
approved these changes
Jun 18, 2025
Contributor
dhlevi
left a comment
dhlevi
left a comment
There was a problem hiding this comment.
Approved, but there are some comments that could be worth addressing.
Casing in some of the codes is erratic and inconsistent. We really should be using proper structure and consistent language. Also, the project_obj_filter_summ table name is kind of weird? summ could be sum or if it's short for summary maybe something that makes that obvious
kcguise
approved these changes
Jun 19, 2025
sukhpalp
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.