Integrated SonarCloud, dropped CodeClimate, fixed on-pr-closed workflow, dropped CodeQL workflow - #351
Merged
Merged
Conversation
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 19, 2025 16:01
9d51a75 to
cc2a0e4
Compare
|
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 19, 2025 22:02
cc2a0e4 to
dae40a8
Compare
Coverage Report (Application)
|
Coverage Report (Frontend)
|
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 19, 2025 23:09
f2fbf58 to
4f834c2
Compare
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 19, 2025 23:48
4f834c2 to
5e7170d
Compare
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 20, 2025 15:30
5e7170d to
d7f82f5
Compare
Referenced nr-peach for these changes
Aligns with new bcgov standard/ability to use github default setup
Only adds comment if GitHub event is a pull request, previously push events would run this still.
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 20, 2025 15:51
d7f82f5 to
9a0e4db
Compare
qhanson55
force-pushed
the
chore/sonar-cloud
branch
from
August 20, 2025 16:06
9a0e4db to
a224b2a
Compare
qhanson55
marked this pull request as ready for review
August 20, 2025 16:06
qhanson55
changed the title
kyle1morel
approved these changes
Aug 20, 2025
sanjaytkbabu
approved these changes
Aug 20, 2025
jujaga
approved these changes
Aug 20, 2025
|
|
kyle1morel
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed Code Climate and integrated SonarCloud
PADS-614
Fixed
on-pr-closedworkflow, PADS-612Now all OpenShift resources are being removed with helm command, new
pipelineSA was missing admin role to remove a PR's Patroni RBAC.Note: No change to code for this, just had to add new role binding on OpenShift for the
pipelineSA.Also dropped the CodeQL workflow file and switch over to CodeQL defaults
Referenced
nr-peachfor all these changesTypes of changes
Tech debt
&
Bug fix (non-breaking change which fixes an issue)
Checklist