Skip to content

Navigator Note Card Update - #353

Merged
kyle1morel merged 1 commit into
feature/note-releasefrom
feature/nav-note-card-update
Sep 3, 2025
Merged

Navigator Note Card Update#353
kyle1morel merged 1 commit into
feature/note-releasefrom
feature/nav-note-card-update

Conversation

@sanjaytkbabu

@sanjaytkbabu sanjaytkbabu commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Description

PADS-577

Navigator note card updates

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions

Copy link
Copy Markdown

Coverage Report (Application)

Totals Coverage
Statements: 47.01% ( 2402 / 5110 )
Methods: 34.6% ( 292 / 844 )
Lines: 60.72% ( 1685 / 2775 )
Branches: 28.5% ( 425 / 1491 )

@Subin1Doo

Copy link
Copy Markdown

The icon and the text colour for 'shown to proponent' label should be the gov primary blue. Can we increase the corner radius to 4px for both labels?

For the title hyperlink, can we make it behave the same as Authorization cards? The underline for title should show when user hovers over the title area.

And for the vertical bars between the title, bf value, and escalation type, can we make them a big shorter in height so it's somewhat similar to the text height and darken the colour a little bit?

Thanks!

@sanjaytkbabu
sanjaytkbabu force-pushed the feature/nav-note-card-update branch from 9aa96fd to f399725 Compare August 27, 2025 14:59
@sanjaytkbabu
sanjaytkbabu marked this pull request as ready for review August 27, 2025 14:59
@sanjaytkbabu
sanjaytkbabu requested a review from a team as a code owner August 27, 2025 14:59
@sanjaytkbabu sanjaytkbabu reopened this Aug 27, 2025
@github-actions

github-actions Bot commented Aug 27, 2025

Copy link
Copy Markdown

Coverage Report (Frontend)

Totals Coverage
Statements: 41.07% ( 4078 / 9930 )
Methods: 28.85% ( 496 / 1719 )
Lines: 49.95% ( 2555 / 5115 )
Branches: 33.17% ( 1027 / 3096 )

@github-actions

github-actions Bot commented Aug 27, 2025

Copy link
Copy Markdown

@slhurley

Copy link
Copy Markdown
Contributor
  • When the note is very long and the ellipsis kick in it is a bit too close to the Edit button and also then the Edit button is a different size than it is on the shorter notes and the word Edit is not centered.
    Otherwise looks good from my perspective!

@Subin1Doo

Copy link
Copy Markdown

just realized we're missing the bf date for bf notes! It should come after the last updated date. Everything else looks good, thanks!

@sanjaytkbabu
sanjaytkbabu force-pushed the feature/nav-note-card-update branch 2 times, most recently from e3cafd5 to 677a893 Compare August 27, 2025 16:42
Comment thread frontend/src/components/authorization/AuthorizationCard.vue Outdated
Comment thread frontend/src/components/common/StatusPill.vue Outdated
@sanjaytkbabu
sanjaytkbabu force-pushed the feature/nav-note-card-update branch from 677a893 to a412a66 Compare August 27, 2025 18:00
@sanjaytkbabu
sanjaytkbabu force-pushed the feature/nav-note-card-update branch from a412a66 to 392a5f7 Compare August 27, 2025 20:15
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'nr-permitconnect-navigator-service app'

Failed conditions
63.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'nr-permitconnect-navigator-service frontend'

Failed conditions
78.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@kyle1morel
kyle1morel merged commit f687ce3 into feature/note-release Sep 3, 2025
15 of 18 checks passed
@kyle1morel
kyle1morel deleted the feature/nav-note-card-update branch September 3, 2025 18:33
@sanjaytkbabu sanjaytkbabu mentioned this pull request Sep 23, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants