Skip to content

chore: update COMS service - #449

Merged
qhanson55 merged 1 commit into
masterfrom
chore/coms
Mar 30, 2026
Merged

chore: update COMS service#449
qhanson55 merged 1 commit into
masterfrom
chore/coms

Conversation

@kyle1morel

Copy link
Copy Markdown
Collaborator

Use pseudo service account where required. Update how COMS permissions are applied for external users.

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions

Copy link
Copy Markdown

Coverage Report (Frontend)

Totals Coverage
Statements: 55.07% ( 5975 / 10850 )
Methods: 43.78% ( 838 / 1914 )
Lines: 63.81% ( 3588 / 5623 )
Branches: 46.76% ( 1549 / 3313 )

@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown

Coverage Report (Application)

Totals Coverage
Statements: 79.33% ( 3680 / 4639 )
Methods: 75.53% ( 460 / 609 )
Lines: 85.26% ( 2579 / 3025 )
Branches: 63.78% ( 641 / 1005 )

Comment thread app/src/services/coms.ts Outdated
Comment thread app/src/services/coms.ts Outdated
Comment thread app/src/services/coms.ts Outdated
Comment thread app/src/services/coms.ts Outdated
Use pseudo service account where required. Update how COMS permissions are applied for external users.
@kyle1morel
kyle1morel marked this pull request as ready for review March 30, 2026 21:51
@kyle1morel
kyle1morel requested a review from a team as a code owner March 30, 2026 21:51
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'nr-permitconnect-navigator-service app'

Failed conditions
14.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'nr-permitconnect-navigator-service frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@qhanson55
qhanson55 merged commit cc7f747 into master Mar 30, 2026
20 of 21 checks passed
@renovate
renovate Bot deleted the chore/coms branch March 30, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants