Skip to content

Comments

ORV2-3166 Staff payment options behind feature flag#1727

Merged
krishnan-aot merged 6 commits intomainfrom
3166
Jan 6, 2025
Merged

ORV2-3166 Staff payment options behind feature flag#1727
krishnan-aot merged 6 commits intomainfrom
3166

Conversation

@krishnan-aot
Copy link
Contributor

@krishnan-aot krishnan-aot commented Jan 6, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

image

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@krishnan-aot krishnan-aot added dont review dont merge a branch for anything that shouldn't be merged (yet or ever) labels Jan 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
19.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@krishnan-aot krishnan-aot merged commit 6e21bb1 into main Jan 6, 2025
23 of 24 checks passed
@krishnan-aot krishnan-aot deleted the 3166 branch January 6, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont merge a branch for anything that shouldn't be merged (yet or ever) dont review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants