Skip to content

Comments

Code Refactor - Cache Module#2041

Merged
praju-aot merged 1 commit intomainfrom
fix/cache-refactor
May 28, 2025
Merged

Code Refactor - Cache Module#2041
praju-aot merged 1 commit intomainfrom
fix/cache-refactor

Conversation

@praju-aot
Copy link
Contributor

@praju-aot praju-aot commented May 28, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Refactor getMapFromCache() method to return Map< string, string> object instead of Record<string, string>

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Feature Flag
  • Reports

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Refactor getMapFromCache() method to return Map< string, string> object instead of Record<string, string>
@praju-aot praju-aot requested a review from gchauhan-aot as a code owner May 28, 2025 21:51
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc vehicles'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

@praju-aot praju-aot merged commit bd111e5 into main May 28, 2025
25 of 27 checks passed
@praju-aot praju-aot deleted the fix/cache-refactor branch May 28, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants