Skip to content

Comments

ORV2-4592 - FE: Utilize updated Amend, Void Fee Summary Table in Review and Confirm page#2054

Merged
glen-aot merged 3 commits intomainfrom
ORV2-4592
Jun 6, 2025
Merged

ORV2-4592 - FE: Utilize updated Amend, Void Fee Summary Table in Review and Confirm page#2054
glen-aot merged 3 commits intomainfrom
ORV2-4592

Conversation

@glen-aot
Copy link
Contributor

@glen-aot glen-aot commented Jun 6, 2025

Description

Conditionally render AmendOrVoidFeeSummary component inside ReviewFeeSummary

Fixes #ORV2-4592

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
70.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@glen-aot glen-aot merged commit bdc7cf5 into main Jun 6, 2025
26 of 27 checks passed
@glen-aot glen-aot deleted the ORV2-4592 branch June 6, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants