Skip to content

ORV2 - 3144 - FE: added the limit of 63500 in the vehicle inventory tab. #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishek-dere merged 8 commits into from
Jul 9, 2025
Merged

ORV2 - 3144 - FE: added the limit of 63500 in the vehicle inventory tab. #2091

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4becd4b
added the limit of 63500 to the FE
abhishek-dere Jul 8, 2025
e08a408
test
abhishek-dere Jul 8, 2025
0b109af
Merge branch 'main' into ORV2-4767-FE--Update--Licensed-GVW-(kg)-cann…
abhishek-dere Jul 9, 2025
2491ba2
Merge branch 'main' of https://github.com/bcgov/onroutebc into ORV2-4…
abhishek-dere Jul 9, 2025
7565b9c
reverting changes
abhishek-dere Jul 9, 2025
581fc94
Merge branch 'ORV2-4767-FE--Update--Licensed-GVW-(kg)-cannot-exceed-6…
abhishek-dere Jul 9, 2025
fe5f0b6
Merge branch 'main' of https://github.com/bcgov/onroutebc into ORV2-4…
abhishek-dere Jul 9, 2025
dd6ffa9
adding the value to be under the limit
abhishek-dere Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/common/constants/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ export const DEFAULT_EMPTY_SELECT_OPTION = {
export const DEFAULT_SELECT_OPTIONS = [DEFAULT_EMPTY_SELECT_OPTION];

export const EMPTY_VEHICLE_UNIT_NUMBER = DEFAULT_EMPTY_SELECT_VALUE;

//Inventory GVW
export const GVW_LIMIT = 63500;
5 changes: 5 additions & 0 deletions frontend/src/features/manageVehicles/components/form/PowerUnitForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ import {
invalidPlateLength,
invalidVINLength,
invalidYearMin,
licensedGVWExceeded,
requiredMessage,
} from "../../../../common/helpers/validationMessages";
import { ORBC_FORM_FEATURES } from "../../../../common/types/common";
import { GVW_LIMIT } from "../../../../common/constants/constants";

const FEATURE = ORBC_FORM_FEATURES.POWER_UNIT;

Expand Down Expand Up @@ -258,6 +260,9 @@ export const PowerUnitForm = ({
required: { value: true, message: requiredMessage() },
validate: {
isNumber: (v) => !isNaN(v) || invalidNumber(),
lessThanMax: (v) =>
parseFloat(v) < GVW_LIMIT ||
licensedGVWExceeded(GVW_LIMIT, true),
},
},
inputType: "number",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/features/manageVehicles/components/form/tests/helpers/assert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@
}

// Assert - no errors shown after submission
expect(async () => await submitErrorsDisplay()).rejects.toThrow();
await expect(submitErrorsDisplay()).rejects.toThrow();

Check failure on line 53 in frontend/src/features/manageVehicles/components/form/tests/helpers/assert.ts

View workflow job for this annotation

GitHub Actions / Tests (frontend)

src/features/manageVehicles/components/form/tests/PowerUnitForm.test.tsx > Power Unit Form Submission > should successfully submit form without errors shown on ui 

AssertionError: promise resolved "<p …(2)></p>" instead of rejecting

- Expected
+ Received

- [Error: rejected promise]
+ <p
+   class="MuiFormHelperText-root Mui-error MuiFormHelperText-sizeMedium MuiFormHelperText-contained Mui-focused MuiFormHelperText-filled custom-form-control__helper-text css-1wc848c-MuiFormHelperText-root"
+   data-testid="alert-licensedGvw"
+ >
+   Can't Exceed 63,500
+ </p>

 ❯ Module.assertSuccessfulSubmit src/features/manageVehicles/components/form/tests/helpers/assert.ts:53:16
 ❯ src/features/manageVehicles/components/form/tests/PowerUnitForm.test.tsx:159:5
};
Loading