Skip to content

Comments

ORV2-4773: Prevent both staff and non-staff users from proceeding upon non-resident policy vehicle weight violations#2101

Merged
zgong-gov merged 4 commits intomainfrom
ORV2-4773
Jul 14, 2025
Merged

ORV2-4773: Prevent both staff and non-staff users from proceeding upon non-resident policy vehicle weight violations#2101
zgong-gov merged 4 commits intomainfrom
ORV2-4773

Conversation

@zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Jul 14, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Add helper to override permit policy violations when needed, add check for non-resident vehicle weight policy violations

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Login as staff, and create a new non-resident permit application, and enter an invalid large number for vehicle weight (either loaded GVW or net weight, depending on which conditional licensing fee type is selected). Observe that a policy violation will occur, and that the user cannot proceed to the review and confirm page upon trying to continue.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

…k for non-resident vehicle weight policy violations
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
26.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@zgong-gov zgong-gov merged commit 82a70a4 into main Jul 14, 2025
28 of 29 checks passed
@zgong-gov zgong-gov deleted the ORV2-4773 branch July 14, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants