Skip to content

Comments

ORV2-4816 DA feedback for v78 and v79#2107

Merged
praju-aot merged 2 commits intomainfrom
ORV2-4816
Jul 14, 2025
Merged

ORV2-4816 DA feedback for v78 and v79#2107
praju-aot merged 2 commits intomainfrom
ORV2-4816

Conversation

@praju-aot
Copy link
Contributor

@praju-aot praju-aot commented Jul 14, 2025

Description

Incorporating feedback from DA on versions 78 and 79 of the scripts.

  • Expand the extended property description for that column to state the data integrity rule.
  • Add a unique key constraint on USER_DIRECTORY + USER_GUID + LOGIN_DATE_TIME to ORBC_LOGIN.
  • An extended property description at the table level to state the rule that one row is inserted for every login and there is no update or delete from the application.
  • ORBC_LOGIN_HIST is not needed as it will always contain the same data as ORBC_LOGIN.
  • Add an extended property description to application metadata columns in ORBC_LOGIN.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@praju-aot praju-aot merged commit 18a278e into main Jul 14, 2025
39 of 40 checks passed
@praju-aot praju-aot deleted the ORV2-4816 branch July 14, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants