Skip to content

Comments

ORV2-4229 - Permit with unfinished amendments cannot be voided#2119

Merged
glen-aot merged 4 commits intomainfrom
ORV2-4229
Jul 23, 2025
Merged

ORV2-4229 - Permit with unfinished amendments cannot be voided#2119
glen-aot merged 4 commits intomainfrom
ORV2-4229

Conversation

@glen-aot
Copy link
Contributor

@glen-aot glen-aot commented Jul 22, 2025

Description

add navigation state to PermitRowOptions, export deleteAmendmentApplication function from useAttemptAmend hook, check if amendment application exists in FinshVoid and delete it if so

Fixes #ORV2-4229

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

glen-aot added 2 commits July 22, 2025 11:06
…cation function from useAttemptAmend hook, check if amendment application exists in FinshVoid and delete it if so
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
31.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@glen-aot glen-aot merged commit c0c2984 into main Jul 23, 2025
28 of 29 checks passed
@glen-aot glen-aot deleted the ORV2-4229 branch July 23, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants