Skip to content

Comments

ORV2-4887 - Refund to multiple payments screen missing Cancel button#2122

Merged
praju-aot merged 3 commits intofeature/frcr-release-bundle-1from
ORV2-4887
Jul 29, 2025
Merged

ORV2-4887 - Refund to multiple payments screen missing Cancel button#2122
praju-aot merged 3 commits intofeature/frcr-release-bundle-1from
ORV2-4887

Conversation

@glen-aot
Copy link
Contributor

@glen-aot glen-aot commented Jul 24, 2025

Description

update VoidPermitContext so that it includes permit, goHome, goHomeSuccess and handleFail (similar to how AmendPermitContext is structured). Remove these objects which were previously passed as props to VoidPermit and VoidPermitForm. Implement 'Cancel' button on RefundPage which calls the appropriate action based on the context in which RefundPage is rendered.

Fixes #ORV2-4887

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

…ccess and handleFail (similar to how AmendPermitContext is structured). Remove these objects which were previously passed as props to VoidPermit and VoidPermitForm. Implement 'Cancel' button on RefundPage which calls the appropriate action based on the context in which RefundPage is rendered.
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
31.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

@praju-aot praju-aot merged commit 1d25b0d into feature/frcr-release-bundle-1 Jul 29, 2025
29 of 34 checks passed
@praju-aot praju-aot deleted the ORV2-4887 branch July 29, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants