Skip to content

Comments

ORV2-5192: Use Commercial Passenger Vehicle conditional licensing fee type for certain Non-Resident vehicle subtypes#2204

Merged
zgong-gov merged 3 commits intorelease/onroutebc-release-47from
ORV2-5192
Dec 15, 2025
Merged

ORV2-5192: Use Commercial Passenger Vehicle conditional licensing fee type for certain Non-Resident vehicle subtypes#2204
zgong-gov merged 3 commits intorelease/onroutebc-release-47from
ORV2-5192

Conversation

@zgong-gov
Copy link
Collaborator

@zgong-gov zgong-gov commented Dec 11, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

  • Fix incorrect fees for "Buses", "Double Decker Buses", and "Taxis" for Non-Resident permit types
  • Add and use new "Commercial Passenger Vehicle" conditional licensing fee type to frontend, backend, and policy engine

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Observe that all vehicle subtypes for non-resident permit types yield correct fees
  • Observe that for the vehicle subtypes "Buses", "Double Decker Buses", and "Taxis", the only selectable conditional licensing fees are "Conditional" and "Commercial Passenger Vehicle", and that the fees yielded by both options are correct

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@zgong-gov zgong-gov merged commit 3470065 into release/onroutebc-release-47 Dec 15, 2025
16 of 22 checks passed
@zgong-gov zgong-gov deleted the ORV2-5192 branch December 15, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant