Conversation
…-test-suite Add Graphemes API build check to test suite
…loyment Add trigger to graphemes-api dev deployment YAML
Bump Graphemes API dependencies
Use GHCR image repository for Graphemes API
ty2k
added
the
promotion
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dev deployment and CI workflows to prepare for promoting the dev environment into a test environment, by adding an OpenShift image trigger and standardizing the GitHub Actions test/build pipelines.
- Adds an ImageChange trigger to the dev deployment so it redeploys on new image tags
- Introduces a default working directory and explicit build step in the test workflow
- Replaces manual Docker build/push in the build workflow with a GHCR builder action
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| graphemes-api/openshift/dev/deployment.yaml | Added triggers block to automatically redeploy on image changes |
| .github/workflows/graphemes_api_test.yaml | Added defaults for working directory and a build validation step |
| .github/workflows/graphemes_api_build.yaml | Swapped manual Docker steps for bcgov-nr/action-builder-ghcr |
Files not reviewed (1)
- graphemes-api/package.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/graphemes_api_test.yaml:41
- Consider adding a caching step (using
actions/cache@v3for~/.npm) before installing dependencies to reuse node_modules and reduce CI runtime.
run: npm install
| - graphemes-api | ||
| from: | ||
| kind: ImageStreamTag | ||
| name: graphemes-api:dev |
There was a problem hiding this comment.
The deployment trigger is watching an internal ImageStreamTag, but your new build pipeline pushes images to GHCR. Without a mirror or import step into OpenShift, the trigger won’t fire. Consider either pushing into the ImageStreamTag or adding an oc import-image step after publishing to GHCR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.