Conversation
Promote test to main
Promote test to main
Promote test to main
Promote test to main
Graphemes API build workflow gets write permission to GHCR
Docs/graphemes api readme
Update dev Graphemes API deployment to use GHCR
ty2k
added
the
promotion
There was a problem hiding this comment.
Pull Request Overview
Updates the development deployment to reference the GitHub Container Registry image and remove OpenShift triggers, adds build instructions to the repository README, and adjusts workflow permissions to allow pushing images.
- Remove OpenShift image triggers and update the container image in
dev/deployment.yaml - Add a “Build” section to README linking to the GitHub Actions workflow
- Grant
packages: writepermission in the build workflow for pushing to the registry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| graphemes-api/openshift/dev/deployment.yaml | Remove obsolete triggers/annotations and switch image to GHCR |
| graphemes-api/README.md | Add Build section with link to the build workflow |
| .github/workflows/graphemes_api_build.yaml | Expand GitHub Actions permissions to include packages: write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.