Added unit test for #319 and fixed issue #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_with_very_large_range_succeeds to Bogus.Tests. Updated Randomizer.Decimal to make the test pass.
…ate methods GenerateRandomMaximumPrecisionDecimal and ScaleMaximumPrecisionDecimalToRange. Added unit tests to RandomizerTest.cs. Tweaked the implementation of GenerateRandomMaximumPrecisionDecimal and ScaleMaximumPrecisionDecimalToRange based on observations driven by the tests.
bchavez
added a commit
that referenced
this pull request
Aug 15, 2020
bchavez
force-pushed
the
master
branch
3 times, most recently
from
ae40cad to
67a312d
Compare
bchavez
force-pushed
the
master
branch
15 times, most recently
from
8107b9f to
18cc743
Compare
bchavez
force-pushed
the
master
branch
14 times, most recently
from
0b65acc to
cc799df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a unit test for issue #319 highlighting the issues with the new
Decimal()implementation for very large ranges.Added code to
Randomizer.Decimalto detect these situations and compensate for them, keeping as many digits of precision as possible.