Skip to content

Conversation

@Perks-of-Being-a-Cauliflower
Copy link
Contributor

Issue #565.
Provides alternate solution to pull request #602.
Adds person class by modifying tokenizer to use class properties getters as methods.
It's a little bit messy because of limitations of older supported .NET versions.
Requirements:

  • No extra state to manage.
  • Easily expanded if Person got more properties or if another class needed its properties added.
  • Utilize similar design as existing method registration to avoid creating deviations in process.
  • Modify as little of the existing code as possible to avoid introducing unforeseen bugs in existing functionality.
  • Avoid redefining existing classes/functionality to avoid overhead.

@Perks-of-Being-a-Cauliflower
Copy link
Contributor Author

Hi @bchavez
Hopefully this is more what you had in mind. I feel like my code could maybe be a bit cleaner, but I had to fight against the older .NET versions and some other weirdness. At the very least it should act as a proof of concept should this be the route you want to go down.

…e Class itself. Should mean that the test will work even if the underlying generation changes as has happened with the Avatar field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant