Skip to content

chore: deep review cleanup — drop eval-run artifacts, sync docs, fix stale paths - #2

Merged
bcmyguest merged 1 commit into
mainfrom
claude/deep-review-cleanup-0att0g
Jul 16, 2026
Merged

bcmyguest merged 1 commit into
mainfrom
claude/deep-review-cleanup-0att0g

Conversation

@bcmyguest

Copy link
Copy Markdown
Owner
  • remove committed eval-run outputs (security-audit-workspace/,
    efficiency-audit-workspace/, _fixtures/run_map.json) and gitignore the
    pattern; keep the vuln-app fixture the evals reference
  • evals.json (both audits): machine-specific /home/bguest absolute fixture
    paths -> repo-relative skills/_fixtures/vuln-app
  • README + skills.sh.json: add the missing security-audit and
    efficiency-audit skills (table, layout, new Audits/Debugging groupings)
  • IDEAS.md: fix stale claude-memory/ locations for fast-hypothesis and
    reproduce-bug (they live in this repo)
  • assign-mr-reviewers: reference the script relative to the skill dir
    instead of a hardcoded ~/.claude path (portable across agents); report
    no_eligible_candidates instead of already_has_reviewers when reviewers
    are needed but everyone is excluded
  • fast-hypothesis / reproduce-bug: add "Use when" trigger phrasing to
    descriptions, matching the rest of the repo

Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_017WKCdwpi8LBorsiztvhZss

…stale paths

- remove committed eval-run outputs (security-audit-workspace/,
  efficiency-audit-workspace/, _fixtures/run_map.json) and gitignore the
  pattern; keep the vuln-app fixture the evals reference
- evals.json (both audits): machine-specific /home/bguest absolute fixture
  paths -> repo-relative skills/_fixtures/vuln-app
- README + skills.sh.json: add the missing security-audit and
  efficiency-audit skills (table, layout, new Audits/Debugging groupings)
- IDEAS.md: fix stale claude-memory/ locations for fast-hypothesis and
  reproduce-bug (they live in this repo)
- assign-mr-reviewers: reference the script relative to the skill dir
  instead of a hardcoded ~/.claude path (portable across agents); report
  no_eligible_candidates instead of already_has_reviewers when reviewers
  are needed but everyone is excluded
- fast-hypothesis / reproduce-bug: add "Use when" trigger phrasing to
  descriptions, matching the rest of the repo

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017WKCdwpi8LBorsiztvhZss
Copilot AI review requested due to automatic review settings July 16, 2026 17:34
@bcmyguest
bcmyguest merged commit 72c8525 into main Jul 16, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up committed audit/eval run artifacts, makes the audit eval fixtures portable by switching from machine-specific absolute paths to repo-relative paths, and synchronizes documentation/groupings so the new audit and debugging skills show up consistently across the repo.

Changes:

  • Removed generated eval-run outputs/benchmarks from the repo and added .gitignore patterns to prevent re-committing them.
  • Updated security-audit / efficiency-audit eval fixtures and prompts to use repo-relative fixture paths.
  • Updated docs and skill metadata (README, skills.sh.json, IDEAS, SKILL.md descriptions) and made assign-mr-reviewers script path + status reporting more portable/precise.

Reviewed changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
skills/security-audit/evals/evals.json Switch eval fixture/prompt paths to repo-relative fixture location.
skills/efficiency-audit/evals/evals.json Switch eval fixture/prompt paths to repo-relative fixture location.
skills/reproduce-bug/SKILL.md Expand description with consistent “Use when …” trigger phrasing.
skills/fast-hypothesis/SKILL.md Expand description with consistent “Use when …” trigger phrasing.
skills/assign-mr-reviewers/SKILL.md Document portable script path resolution and new status meaning.
skills/assign-mr-reviewers/scripts/assign_mr_reviewers.py Refine “no picks” status to distinguish “already has reviewers” vs “no eligible candidates”.
skills.sh.json Add new “Audits” and “Debugging” groupings including the new skills.
README.md Add missing skills to the table and document their locations in the repo layout section.
IDEAS.md Fix stale skill locations to point at this repo’s skills/ paths.
.gitignore Ignore generated skills/*-workspace/ outputs and skills/_fixtures/run_map.json.
skills/_fixtures/run_map.json Remove committed run-map artifact.
skills/security-audit-workspace/iteration-1/eval-1/without_skill/timing.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-1/without_skill/outputs/report.md Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-1/without_skill/grading.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-1/with_skill/timing.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-1/with_skill/outputs/report.md Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-1/with_skill/grading.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-1/eval_metadata.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/without_skill/timing.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/without_skill/outputs/report.md Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/without_skill/grading.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/with_skill/timing.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/with_skill/outputs/report.md Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/with_skill/grading.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/eval-0/eval_metadata.json Remove committed eval-run artifact.
skills/security-audit-workspace/iteration-1/benchmark.md Remove committed benchmark artifact.
skills/security-audit-workspace/iteration-1/benchmark.json Remove committed benchmark artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/without_skill/timing.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/without_skill/outputs/report.md Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/without_skill/grading.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/with_skill/timing.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/with_skill/outputs/report.md Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/with_skill/grading.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-1/eval_metadata.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/without_skill/timing.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/without_skill/outputs/report.md Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/without_skill/grading.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/with_skill/timing.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/with_skill/outputs/report.md Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/with_skill/grading.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/eval-0/eval_metadata.json Remove committed eval-run artifact.
skills/efficiency-audit-workspace/iteration-1/benchmark.md Remove committed benchmark artifact.
skills/efficiency-audit-workspace/iteration-1/benchmark.json Remove committed benchmark artifact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 275 to +279
if not picks:
output["status"] = "already_has_reviewers"
needed = required - len(details["reviewers"])
output["status"] = (
"already_has_reviewers" if needed <= 0 else "no_eligible_candidates"
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants