feat: composable sdk core#1
Conversation
|
@claude[agent] Please provide a review for this repo |
|
@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
5 similar comments
|
@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
fichiokaku
left a comment
There was a problem hiding this comment.
Overall looks good to me, left one comment on this PR.
Also, I've noticed viem extension approach isnt implemented here, would we add that later or we intentionally are not going in that direction?
Same goes for approve(), wrap(), transfer() convenience functions mentioned in the original sdk spec, are we not going with those?
Viem extension is not required here. We decided to add viem extension to extend the functionality of simulations and etc... However, the current SDK only deals with calldata generation and simulation can be done directly with viem or any other web3 library. This is intentional to keep this modular and developers decide how to simulate and broadcast transactions. Regarding the ERC20 flows: This is a standard general way which supports all the token convenience functions and same can be achieved for arbitrary contract with contract instance instead. |
No description provided.