Skip to content

feat: composable sdk core#1

Merged
vr16x merged 24 commits into
mainfrom
feat/initial-composable-setup
Apr 23, 2026
Merged

feat: composable sdk core#1
vr16x merged 24 commits into
mainfrom
feat/initial-composable-setup

Conversation

@vr16x

@vr16x vr16x commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@vr16x

vr16x commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator Author

@claude[agent] Please provide a review for this repo

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown

@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c3d29155-977c-4702-8d76-d5ee91808783

Sorry for the inconvenience!

5 similar comments
@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown

@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c3d29155-977c-4702-8d76-d5ee91808783

Sorry for the inconvenience!

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown

@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c3d29155-977c-4702-8d76-d5ee91808783

Sorry for the inconvenience!

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown

@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c3d29155-977c-4702-8d76-d5ee91808783

Sorry for the inconvenience!

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown

@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c3d29155-977c-4702-8d76-d5ee91808783

Sorry for the inconvenience!

@Claude

Claude AI commented Apr 3, 2026

Copy link
Copy Markdown

@vr16x Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: c3d29155-977c-4702-8d76-d5ee91808783

Sorry for the inconvenience!

@vr16x vr16x changed the title feat: initial composable setup feat: composable sdk core Apr 14, 2026
@vr16x
vr16x requested review from fichiokaku and oxshaman April 15, 2026 11:18

@fichiokaku fichiokaku left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, left one comment on this PR.

Also, I've noticed viem extension approach isnt implemented here, would we add that later or we intentionally are not going in that direction?

Same goes for approve(), wrap(), transfer() convenience functions mentioned in the original sdk spec, are we not going with those?

Comment thread src/core/storage/storage.ts
@vr16x

vr16x commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator Author

Overall looks good to me, left one comment on this PR.

Also, I've noticed viem extension approach isnt implemented here, would we add that later or we intentionally are not going in that direction?

Same goes for approve(), wrap(), transfer() convenience functions mentioned in the original sdk spec, are we not going with those?

Viem extension is not required here.

We decided to add viem extension to extend the functionality of simulations and etc... However, the current SDK only deals with calldata generation and simulation can be done directly with viem or any other web3 library. This is intentional to keep this modular and developers decide how to simulate and broadcast transactions.

Regarding the convenience functions, it is already supported via write method and we have already discussed about this in TG.

ERC20 flows:

const batch = createComposableBatch(...);
const usdc = batch.erc20Token('0xUsdcAddress');

usdc.write({ functionName: 'transfer', args: ['0xRecipientAddress', usdc.runtimeBalance()] })

This is a standard general way which supports all the token convenience functions and same can be achieved for arbitrary contract with contract instance instead.

@vr16x
vr16x merged commit d1592fb into main Apr 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants