Fixed Robber Disabling Entire Settlements Instead of Tile#358
Merged
Conversation
👷 Deploy request for catanatron-staging pending review.Visit the deploys page to approve it
|
pachewise
approved these changes
Mar 18, 2026
Owner
|
Hey, this looks great! Mind adding a test that reproduces issue (i.e. is red before the change, and green afterwards)? Thanks! 🚀 |
Contributor
Author
|
Sure, just added one |
bcollazo
approved these changes
Mar 19, 2026
bcollazo
left a comment
bcollazo
left a comment
Owner
There was a problem hiding this comment.
Hey Jake, thanks for this. Looks good to me. Could you merge in the latest changes from main and address any CI failures? I fixed the CI in the latest commit in main. Thanks! 🚀
Pull Request Test Coverage Report for Build 23323031853Details
💛 - Coveralls |
Owner
|
Awesome! Thanks for the great contribution. Definitely should make Catanatron stronger! 💪 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The robber was disabling and buildings on nodes connected to the robbed tile, but this meant these buildings could not collect resources from unrobbed tiles, which did not fit Catan's rules.
Fixes #350