Conversation
bcomnes
added this pull request to stack #330
September 15, 2026 19:15
Coverage Report for CI Build 35044789684Coverage increased (+0.1%) to 95.451%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
bcomnes
force-pushed
the
feat/incremental-global-data-watch-optimizations
branch
2 times, most recently
from
September 15, 2026 20:33
cbad527 to
5eb0ad6
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate issues remain in watcher reset and browser dependency recovery handling.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves watch dependency tracking and rebuild routing, including settings, browser, JSON dependencies, targeted rebuilds, tests, and documentation.
Changes:
- Unifies settings dependency tracking and reset behavior.
- Expands targeted and conservative rebuild handling.
- Adds planner, watcher, and imported-JSON coverage.
File summaries
| File | Summary | Findings |
|---|---|---|
test-cases/incremental-global-data/index.test.js |
Incremental and imported-JSON tests. | None |
test-cases/incremental-global-data/helpers.js |
Native watcher test support. | None |
lib/watch-plan.test.js |
Planner regression coverage. | None |
lib/watch-plan.js |
Rebuild scope and reset planning. | None |
index.js |
Dependency tracking, event filtering, and rebuild execution. | Moderate (3 votes): preserve full plans for reset-triggering bundle inputs. Moderate (1 vote): mark failed browser analysis for conservative recovery. |
docs/implementation/README.md |
Watch behavior documentation. | None |
docs/data/README.md |
Tracked-input and reset documentation. | Nit (1 vote): document tracked imports as reset triggers. |
Review details
Suppressed comments (2)
docs/data/README.md:437
- The producer dependency map includes the
global.dataentry and every tracked static import, and changes to any of those paths reset the retained index. This note currently says onlyglobal.data.*resets it, so an imported producer helper is described as an individual-entry update even though editing it emits a reset; please name the tracked imports here.
Changes to `global.data.*` or settings inputs reset the saved index.
index.js:859
- When
find()fails for a browser entry, this catch leavesdependencyAnalysisFailedfalse. A later change to an imported non-processed file such as JSON is then absent fromesbuildDepPathsand is removed by#filterWatchEvents, so the browser bundle remains stale instead of taking the documented conservative recovery path. Mark the analysis as failed here so subsequent events bypass filtering and trigger recovery.
} catch {
// Unknown browser helpers still take the conservative reset path.
}
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bcomnes
force-pushed
the
feat/incremental-global-data-watch-optimizations
branch
from
September 16, 2026 01:37
5635d04 to
03f251f
Compare
bcomnes
deleted the
feat/incremental-global-data-watch-optimizations
branch
September 16, 2026 02:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #326. Keep watch dependency coverage and routing improvements separate from the incremental global-data feature.
Changes
The global-data API, worker state lifecycle, and documentation index are unchanged. No custom dependency analyzer or re-export workaround is added; the upstream limitation remains tracked by #328 and two test TODOs.
Validation
The browser suite was not rerun. See #326 for the two previously observed documentation-navigation timeouts.
Review this PR against #326, not master. Created and submitted using gh stack.