chore(ism): charge gas for signature verification#154
Merged
mbreithecker merged 4 commits intomainfrom Feb 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds gas consumption for signature verification in Interchain Security Modules (ISMs). The changes charge 1000 gas units per signature verified in both MessageIdMultisigISM and MerkleRootMultisigISM implementations.
Changes:
- Added gas metering that charges 1000 gas per signature verification in ISM verify methods
- Updated test files to use proper SDK context instead of empty context for gas tracking
- Added test assertions to verify correct gas consumption
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| x/core/01_interchain_security/types/message_id_multisig.go | Added gas consumption logic for signature verification |
| x/core/01_interchain_security/types/merkle_root_multisig.go | Added gas consumption logic for signature verification |
| x/core/01_interchain_security/types/message_id_multisig_test.go | Updated tests to use KeeperTestSuite for proper context initialization |
| x/core/01_interchain_security/types/merkle_root_multisig_test.go | Updated tests to use KeeperTestSuite and added gas consumption assertions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Charge gas proportional the the signatures the ISM needs to verify.
closes #119