Fix a GUI segfault in 64-bit Windows #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not possible to use [GdkPixbuf.get_pixels] as it will crash on 64-bit Windows. It is not possible to use [GdkPixbuf.from_data] with most backing buffers (for example those based on string/bytes) as GC may cause those to move around in memory, thus breaking the pixbuf. The current assumption is that due to the implementation of [Bigarray] its data buffer is allocated in C and not moved around by GC, thus suitable to use with [GdkPixbuf.from_data]. However, as a trade-off, creating a [Gpointer.region] based on a [Bigarray] does make this code dependent on internal implementation details of [Bigarray]. This patch uses a custom function for creating a [Gpointer.region] of a [Bigarray] as [Gpointer.region_of_bigarray] is even more tightly bound to internal implementation details of [Bigarray].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit message and in the code comment.