GHA: Work around pkgconf issues (cairo2 and lablgtk3)
#1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent dune release uncovered issues with pkgconf (required by cairo2 and lablgtk3) which break some builds. In the current workflow only builds on ubuntu-20.04 are affected (MSVC GUI builds were also broken but these are not yet merged into the workflow). Since we don't rely on pkgconf, we can just remove it and let dune fall back to pkg-config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune 3.17.0 was released just last week. It switched from using
pkg-configtopkgconfas the default withpkg-configas a fallback.pkgconfdoes not seem to work well in all environments (currently the only one breaking in the CI workflow is ubuntu-20.04) and previously working builds would suddenly fail. This does not affect Unison directly but rather cairo2 and lablgtk3, which are needed for Unison GUI.There is no known fix (the problem is unknown -- is it with GHA runners, Ubuntu (or Cygwin in case of Win builds), or pkgconf itself? -- and irrelevant), but we can work around it simply by uninstalling pkgconf and letting dune fall back to pkg-config, which continues to work as previously.