GHA: Add Windows MSVC GUI builds #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdt
reviewed
Dec 7, 2024
Collaborator
|
Yes, btu the answer is we dont't know, try them both and report back on the list. I don't want to not do something that makes sense because somebody else can't handle it. |
Contributor
Author
|
I propose to separate this question from the PR and postpone it. It is not directly relevant for the core of this PR. I will soon push an update. |
A recent dune release uncovered issues with pkgconf (required by cairo2 and lablgtk3) which break some builds. In the current workflow, builds on ubuntu-20.04 and with MSVC are affected. Since we don't rely on pkgconf, we can just remove it and let dune fall back to pkg-config. For MSVC builds we can go even further and try to remove Cygwin from the build environment as much as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new opam recently allowed us to add Windows MSVC builds, just without the GUI. With the help of some minimal patching (which unfortunately has to live in the GHA workflow for as long as the patches have not been integrated upstream), I've now managed to build cairo2 and lablgtk3 with MSVC. Together with Win-native GTK (which is built when necessary by the workflow using gvsbuild), this finally enables full MSVC builds with GUI.
This PR also includes a new GTK packaging script which does not need a POSIX shell.