Improve input reading in the TUI #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Massimo-B you can test the proposed fix by downloading a CI build artifact at https://github.com/bcpierce00/unison/actions/runs/16346806338 |
Reading from input terminal in raw mode (or possibly non-interactive input), it is impossible to get input keypress by keypress. Improve detection of individual keypresses by adding an extremely simple and dumb parser to cover the most basic cases.
Collaborator
|
Apparently the submitter has not tested, but am merging anyway. @Massimo-B Please test post-merge. |
I tested, works as expected. |
Collaborator
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info in commit message and code comments.
Fixes #1134
(#1133 needs to be merged first to get clean CI)