More fixes for BSD make #1140
Merged
More fixes for BSD make #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all local variable definitions together (as was intended already before).
BSD make in NetBSD < 10 and FreeBSD < 13 does not support defining new target-specific local variables. Add a feature test for this to generate appropriate configuration. At the same time, improve code for executing external shell by: - enabling optional exit status check; - allowing to provide a string that is piped directly to stdin of the shell process. This allows for a universal way of providing input even with various non-POSIX compliant shells (don't have to rely on echo or printf); - passing PATH from the environment to the shell process. (This should be the default, but apparently does not (always?) work properly.)
Don't assume that non-empty output on stdout means success. Check for the exact expected string, ignoring any additional output. There is no need for checking the exit status as the expected output can only be produced on success.
Collaborator
|
I tested with make (BSD) and gmake on NetBSD 9, 10 and current, all 6 combinations ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSD make is still actively adding new features and some of the features are recent enough that they can't be used blindly without testing their presence.
This PR improves feature test for
$^(added in #1139) and adds a feature test for target-specific local variables (supported by BSD make since NetBSD 10/FreeBSD 13).