CI: label artifacts with OS versions #1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'd skip the labels for Windows builds. The GHA runners are based on Windows Server version which is meaningless for most users. Also, Windows version compatibility story is simpler, so not having a label is acceptable. In fact, the actual Windows version constraints come from OCaml runtime, but these are not well documented or officially stated anywhere, to my knowledge (silent compatibility breakage has been the norm). |
This is primarily so that it is clear which ubuntu version was used, as builds are unlikely to work on older ones.
Collaborator
Author
OK, dropped. We're likely to be dropping windows builds entirely with the sooner-or-later move to Libre hosting.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily so that it is clear which ubuntu version was used, as builds are unlikely to work on older ones.