Reset preferences to defaults in server process #1152
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of multi-version compatibility and the 'features' mechanism, it is possible for a long-running server process to retain "ghost" values to some preferences when clients with different features connect. This happens when a preference value is set by a previous client but not by the next client (due to it not supporting that preference, for example). To fix this, simply reset the preferences values on the server at every client connection.
Collaborator
|
This is definitely a bug fix; the only potential about it is if it wil be triggered. Passes CI and makes sense on review, so I'm just hitting merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a potential bug when clients of different versions (feature levels) connect to the same server process.