-
Notifications
You must be signed in to change notification settings - Fork 258
Icon cleanup #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon cleanup #1163
Conversation
unison-icon.ai is in Adobe Illustrator format. inkscape (today) read it and wrote svg, so check that in and remove the ai.
This file is not referenced in the sources, and thus appears to have no purpose.
This is from pre-git-history. It's bitmap, not svg. It isn't aligned with the icons we are currently intending to use. Given how icon culture has evolved over the last 25 years, it seems very unlikely we would use it.
This is bitmap and low resolution. It's similar to the svg icons, but monochrome. I'm assuming it's from an earlier time and that we will not use it. If we did want something like this, I think we'd want to modify the whole-word svg file to be monochrome.
This is similar to U.svg, but only one color -- so it doesn't match any source file in the repository. It's not referenced, even though there's a similar file in a win32rc directory.
This requires lablgtk2, and there's no apparent way to use lablgtk3. Today, the standard approach would be to use inkscape.
|
CI passed. If there are no objections, I'll merge after 12 November at 18Z. |
|
I would guess it is safe to remove *.bmp *.gif *.jpg (and I believe *.xpm, too). |
|
Probably we should:
|
|
Looks reasonable to me. As I said at [1], the Icon Theme Spec [2] only requires the png (or xpm for backward compatibility reasons) files with optional SVG support, which the remaining |
|
Thanks. I added that link to the README and raised the issue of renaming U to unison and unison to unison-word. Perhaps that step should happen in this branch. |
|
The .ico file is apparently a container of some sorts.. Try: |
107964f to
2416d68
Compare
|
Thanks; that was a great hint. Updated with information about the ico file. |
These are not referenced in the sources.
These aren't referenced in the sources.
This file is not referenced in the sources. This appears to be a gif version of unison.svg, but confusingly Unison instead of unison.
My best guess is that U.svg was a recreation in svg of the old icon, with some styling changes. Functionally, unison-icon.svg is similar, but with a slightly different shape and shading. Renaming encodes that guess in the repository.
This file intends to capture all knowlege about the purpose and use of icon files.
This PR is a massive, heavy-handed cleanup of the icons directory. It weighs technical debt more heavily than the risk of deleting something, especially because what is removed remains in git history.