Fix 247 and docs on 239 #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #247 by adding graceful handling for writes to destroyed streams/sockets, and documents issue #239 regarding metrics sent during process shutdown.
Changes:
- Added checks in TCP and stream transports to prevent writes to destroyed streams/sockets
- Added comprehensive test coverage for the destroyed stream scenario
- Documented Node.js limitations around sending metrics during process shutdown with alternative approaches
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/transport.js | Added destroyed stream/socket checks before write operations in TCP and stream transports to prevent ERR_STREAM_DESTROYED errors |
| test/transport.js | Added test cases verifying graceful error handling when writing to destroyed streams and successful writes to active streams |
| README.md | Added documentation section explaining Node.js limitations for sending metrics during process exit and provided working alternatives |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #247 and a doc note for #239