Calculate buffer and message size with Buffer.byteLength, not string length #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer length was being calculated using
buffer.lengthbut should be calculated usingBuffer.byteLengthto account for non-ASCII characters whoselengthdiffers from the number of bytes they take up. I was able to get the test that I modified to fail before applying my changes, 9 failures in total but here's the last one:I attempted to replace all usages of
.lengthwithBuffer.byteLengthwhere buffer size is being calculated, hopefully I didn't miss any.