fix(ci): update template with upstream#121
Merged
bdellegrazie merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns the repository’s GitHub Action template with the upstream typescript-action template by consolidating TypeScript configuration, updating tooling/dependencies, and adjusting CI/workflows.
Changes:
- Inlines
tsconfig.base.jsonintotsconfig.jsonand removestsconfig.base.json/tsconfig.eslint.json. - Updates build/lint/test tooling (Rollup sourcemaps off, ESLint config changes, Jest now uses
tsconfig.json). - Updates CI workflows (Checkov config wiring, dist cleanup before rebuild, small workflow comment formatting).
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Moves previously-shared compiler options into the main TS config. |
tsconfig.eslint.json |
Removes the dedicated ESLint TS project config. |
tsconfig.base.json |
Removes the shared base TS config (options moved into tsconfig.json). |
rollup.config.ts |
Disables sourcemap generation in Rollup output. |
package.json |
Updates dependencies/tooling and adjusts packaging to clean dist/ first. |
jest.config.js |
Switches ts-jest to use tsconfig.json. |
eslint.config.mjs |
Updates flat-config setup and TypeScript parser options; removes import plugin wiring. |
.github/workflows/linter.yml |
Adds Checkov config filename and tweaks Checkov enablement line. |
.github/workflows/ci.yml |
Comment-only whitespace/formatting adjustments. |
.github/workflows/check-dist.yml |
Cleans dist/ before rebuilding and diffing. |
.devcontainer/devcontainer.json |
Removes an extension entry. |
.checkov.yml |
Adds a Checkov configuration file. |
Comments suppressed due to low confidence (1)
eslint.config.mjs:33
eslint.config.mjsstill configuresimport/*,eslint-comments/*, andi18n-text/*rules, but those plugins are not registered inpluginsand are not present inpackage.json. ESLint will error with “Definition for rule … was not found” even when the rule is set tooff. Either re-add and register the required plugins, or remove these rule entries.
plugins: {
jest,
prettier,
'@typescript-eslint': typescriptEslint
},
a3cc9ed to
d7be8d9
Compare
Align the action template with typescript-action template
d7be8d9 to
9cdec1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the action template with typescript-action template