Skip to content

fix(ci): update template with upstream#121

Merged
bdellegrazie merged 1 commit intomainfrom
fix/update-template
Mar 19, 2026
Merged

fix(ci): update template with upstream#121
bdellegrazie merged 1 commit intomainfrom
fix/update-template

Conversation

@bdellegrazie
Copy link
Owner

Align the action template with typescript-action template

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the repository’s GitHub Action template with the upstream typescript-action template by consolidating TypeScript configuration, updating tooling/dependencies, and adjusting CI/workflows.

Changes:

  • Inlines tsconfig.base.json into tsconfig.json and removes tsconfig.base.json / tsconfig.eslint.json.
  • Updates build/lint/test tooling (Rollup sourcemaps off, ESLint config changes, Jest now uses tsconfig.json).
  • Updates CI workflows (Checkov config wiring, dist cleanup before rebuild, small workflow comment formatting).

Reviewed changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tsconfig.json Moves previously-shared compiler options into the main TS config.
tsconfig.eslint.json Removes the dedicated ESLint TS project config.
tsconfig.base.json Removes the shared base TS config (options moved into tsconfig.json).
rollup.config.ts Disables sourcemap generation in Rollup output.
package.json Updates dependencies/tooling and adjusts packaging to clean dist/ first.
jest.config.js Switches ts-jest to use tsconfig.json.
eslint.config.mjs Updates flat-config setup and TypeScript parser options; removes import plugin wiring.
.github/workflows/linter.yml Adds Checkov config filename and tweaks Checkov enablement line.
.github/workflows/ci.yml Comment-only whitespace/formatting adjustments.
.github/workflows/check-dist.yml Cleans dist/ before rebuilding and diffing.
.devcontainer/devcontainer.json Removes an extension entry.
.checkov.yml Adds a Checkov configuration file.
Comments suppressed due to low confidence (1)

eslint.config.mjs:33

  • eslint.config.mjs still configures import/*, eslint-comments/*, and i18n-text/* rules, but those plugins are not registered in plugins and are not present in package.json. ESLint will error with “Definition for rule … was not found” even when the rule is set to off. Either re-add and register the required plugins, or remove these rule entries.
    plugins: {
      jest,
      prettier,
      '@typescript-eslint': typescriptEslint
    },

@bdellegrazie bdellegrazie force-pushed the fix/update-template branch 2 times, most recently from a3cc9ed to d7be8d9 Compare March 19, 2026 23:16
Align the action template with typescript-action template
@bdellegrazie bdellegrazie merged commit 8a5988f into main Mar 19, 2026
23 checks passed
@bdellegrazie bdellegrazie deleted the fix/update-template branch March 19, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants