Skip to content

Fix tests 05/2023 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maxim-Filimonov wants to merge 3 commits into from
Closed

Fix tests 05/2023 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d093347
Update book_finder_test.dart
letyletylety Oct 26, 2022
8bca42f
fix typo
letyletylety Oct 26, 2022
f83cc1f
fix tests
Maxim-Filimonov May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/scripts/books.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ class BookInfo {
/// How many people rated the book
final int ratingsCount;

/// Wether the book is mature or not
/// Whether the book is mature or not
final String maturityRating;

/// The content version
Expand Down
9 changes: 5 additions & 4 deletions test/book_finder_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ void main() {
expect(book.info.language, 'en');
expect(book.info.description.isNotEmpty, true);
expect(book.info.maturityRating, 'NOT_MATURE');
expect(book.info.contentVersion, 'preview-1.0.0');

expect(book.info.contentVersion, '0.0.1.0.preview.0');
expect(book.info.industryIdentifiers.first.type, 'ISBN_10');
expect(book.info.industryIdentifiers.first.identifier, '1534461655');
});
Expand Down Expand Up @@ -123,7 +124,7 @@ void main() {
);

expect(books.first.info.title.toLowerCase(),
"harry potter and the philosopher's stone");
"harry potter and the philosopher\'s stone - gryffindor edition");

/// .inauthor
books = await queryBooks(
Expand All @@ -141,15 +142,15 @@ void main() {
/// .inpublisher
books = await queryBooks(
'Scholastic inc',
queryType: QueryType.inauthor,
queryType: QueryType.inpublisher,
maxResults: 1,
printType: PrintType.books,
orderBy: OrderBy.relevance,
);

if (books.isNotEmpty) {
expect(books.first.info.publisher.toLowerCase(),
"scholastic early learners");
"scholastic teaching resources");
}

/// .isbn
Expand Down