Allow Rp Distribution in ring Bunch Distribution. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| rpMin = beam.Rpmin * CLHEP::rad; | ||
| rpMax = beam.Rpmax * CLHEP::rad; | ||
| nonZeroRp = rpMin > 0 || rpMax > 0; | ||
| generateRp = rpMin != rpMax; |
Collaborator
There was a problem hiding this comment.
Is this generate if rpMin and rpMax are non-zero and equal
If only one single, non-zero, value of Rp is required, both Rpmin and Rpmax
should be set to the same value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ringdistribution is a spatial ring only with no xp, yp distribution. Here, I'm adding the ability to optionally give a lower and upperrpand a uniform ring of angles will be created. Can be used for a single value also by setting both min and max to the same value. By default, it's 0 and it reproduces the old behaviour with the same number of random number generator calls as before so it will be reproducible. Beam class data version updated too.