Insert(element) and bdsimsampler definition updated #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if substitute on, the element is now properly substituted. Also, if a string is given now, the element is properly inserted in the sequence.
To run a sampler from a bdsim output one can set the distribution type to "bdsimsampler:sampler", which is otherwise not in BDSIMDistributionTypes.
When setting a distribution to bdsimsampler:SAMPLER, SetDistributionType looks for "bdsimsampler:" to be part of the definition rather than "bdsimsampler" only.
Now eventgeneratorfile:FORMAT can be set in SetDistributionType() as well
lnevay
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the logic of Machine().Insert(element) is fixed and allows to either insert an element by passing an object or a string.
Beam.SetDistributionType() now allows for beams of the kind "bdsimsampler:SAMPLER". Up to now, the function was looking for a match in the BDSIMDistributionTypes list instead.
Tests are included.