Skip to content

Treat diagonal-tailed ij variants like hooky (not flat-tailed) #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Treat diagonal-tailed ij variants like hooky (not flat-tailed) #2947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/font-glyphs/src/letter/latin/lower-il.ptl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,18 +168,18 @@ glyph-block Letter-Latin-Lower-I : begin
'serifedAsymmetric' { Body.Serifed Serifs.SerifedShort Marks.Serifed [XMiddle mode].Serifed para.advanceScaleI Stroke }
'tailed' { Body.Tailed Serifs.None Marks.Serifless [XMiddle mode].Tailed para.advanceScaleI Stroke }
'tailedSerifed' { Body.Tailed Serifs.Hooky Marks.Serifed [XMiddle mode].TailedSerifed para.advanceScaleI Stroke }
'diagonalTailed' { Body.DiagTailed Serifs.None Marks.Serifless [XMiddle mode].Tailed para.advanceScaleI Stroke }
'serifedDiagonalTailed' { Body.DiagTailed Serifs.Hooky Marks.Serifed [XMiddle mode].TailedSerifed para.advanceScaleI Stroke }
'flatTailed' { Body.FlatTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed para.advanceScaleI Stroke }
'serifedFlatTailed' { Body.FlatTailed Serifs.Hooky Marks.Serifed [XMiddle mode].SerifedFlatTailed para.advanceScaleI Stroke }
'diagonalTailed' { Body.DiagTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed para.advanceScaleI Stroke }
'serifedDiagonalTailed' { Body.DiagTailed Serifs.Hooky Marks.Serifed [XMiddle mode].SerifedFlatTailed para.advanceScaleI Stroke }
'semiTailed' { Body.SemiTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed para.advanceScaleI Stroke }
'serifedSemiTailed' { Body.SemiTailed Serifs.Hooky Marks.Serifed [XMiddle mode].SerifedFlatTailed para.advanceScaleI Stroke }
# Decompressed
'hookyDec' { Body.Serifless Serifs.Hooky Marks.Serifed [XMiddle mode].Hooky para.advanceScaleI 0 }
'seriflessDec' { Body.Serifless Serifs.None Marks.Serifless [XMiddle mode].Center para.advanceScaleI 0 }
'tailedDec' { Body.Tailed Serifs.None Marks.Serifless [XMiddle mode].Tailed para.advanceScaleI Stroke }
'diagonalTailedDec' { Body.DiagTailed Serifs.None Marks.Serifless [XMiddle mode].Tailed para.advanceScaleI Stroke }
'flatTailedDec' { Body.FlatTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed para.advanceScaleI Stroke }
'diagonalTailedDec' { Body.DiagTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed para.advanceScaleI Stroke }
'semiTailedDec' { Body.SemiTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed para.advanceScaleI Stroke }
'hookyBottomDec' { Body.HookyBottom Serifs.None Marks.Serifless [XMiddle mode].HookyBottom para.advanceScaleI Stroke }
# R Tail
Expand All @@ -194,8 +194,8 @@ glyph-block Letter-Latin-Lower-I : begin
# Special variants for Tau (which is built using dotlessi)
'tau/tailless' { Body.Serifless Serifs.None Marks.Serifless [XMiddle mode].Center 1 0 }
'tau/tailed' { Body.Tailed Serifs.None Marks.Serifless [XMiddle mode].Tailed 1 Stroke }
'tau/diagonalTailed' { Body.DiagTailed Serifs.None Marks.Serifless [XMiddle mode].Tailed 1 Stroke }
'tau/flatTailed' { Body.FlatTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed 1 Stroke }
'tau/diagonalTailed' { Body.DiagTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed 1 Stroke }
'tau/semiTailed' { Body.SemiTailed Serifs.None Marks.Serifless [XMiddle mode].FlatTailed 1 Stroke }
'tau/shortTailed' { Body.ShortTailed Serifs.None Marks.Serifless [XMiddle mode].Center 1 Stroke }

Expand Down
9 changes: 4 additions & 5 deletions packages/font-glyphs/src/letter/latin/lower-j.ptl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,10 @@ glyph-block Letter-Latin-Lower-J : begin
serif -- false

export : define [DiagonalTailed df top xMiddle] : glyph-proc
local dfHook : DivFrame para.advanceScaleI
include : dispiro
widths.center
flat xMiddle top [heading Downward]
DiagTail.L xMiddle Descender [DiagTail.StdDepth dfHook Stroke] Stroke
DiagTail.L xMiddle Descender [DiagTail.StdDepth df Stroke] Stroke
set-base-anchor "trailing" (xMiddle - [HSwToV HalfStroke]) Descender

define Serifs : namespace
Expand Down Expand Up @@ -98,15 +97,15 @@ glyph-block Letter-Latin-Lower-J : begin
'bentHookSerifless' { "BentHook" Serifs.None XMiddle.BentHook Marks.Serifless Div.BentHook }
'bentHookShortSerifed' { "BentHook" Serifs.Short XMiddle.BentHook Marks.Serifless Div.BentHook }
'bentHookSerifed' { "BentHook" Serifs.Long XMiddle.BentHook Marks.Serifed Div.BentHook }
'diagonalTailedSerifless' { "DiagonalTailed" Serifs.None XMiddle.BentHook Marks.Serifless Div.BentHook }
'diagonalTailedShortSerifed' { "DiagonalTailed" Serifs.Short XMiddle.BentHook Marks.Serifless Div.BentHook }
'diagonalTailedSerifed' { "DiagonalTailed" Serifs.Long XMiddle.BentHook Marks.Serifed Div.BentHook }
'straightSerifless' { "Straight" Serifs.None XMiddle.StraightSerifless Marks.Serifless Div.StraightSerifless }
'straightShortSerifed' { "Straight" Serifs.Short XMiddle.StraightSerifless Marks.Serifless Div.StraightSerifless }
'straightSerifed' { "Straight" Serifs.Long XMiddle.StraightSerifed Marks.Serifed Div.StraightSerifed }
'flatHookSerifless' { "FlatHook" Serifs.None XMiddle.FlatHookSerifless Marks.Serifless Div.FlatHookSerifless }
'flatHookShortSerifed' { "FlatHook" Serifs.Short XMiddle.FlatHookSerifless Marks.Serifless Div.FlatHookSerifless }
'flatHookSerifed' { "FlatHook" Serifs.Long XMiddle.FlatHookSerifed Marks.Serifed Div.FlatHookSerifed }
'diagonalTailedSerifless' { "DiagonalTailed" Serifs.None XMiddle.FlatHookSerifless Marks.Serifless Div.FlatHookSerifless }
'diagonalTailedShortSerifed' { "DiagonalTailed" Serifs.Short XMiddle.FlatHookSerifless Marks.Serifless Div.FlatHookSerifless }
'diagonalTailedSerifed' { "DiagonalTailed" Serifs.Long XMiddle.FlatHookSerifed Marks.Serifed Div.FlatHookSerifed }

foreach { suffix { shapeId Serif xMiddleT Marks adws } } [Object.entries JConfig] : do
local df : DivFrame adws
Expand Down