5.10 arm64 #275

ravi-rahul · 2022-11-15T13:00:42Z

Revert the HACKs and fix the issue in DSI driver

This reverts commit feab9c3.

This reverts commit 11b74d8.

This reverts commit 33d13f2.

This reverts commit 1bb68a9.

This reverts commit 4d8f9a9.

This reverts commit 575642d.

Phy is not being initialized after suspend resume. Fix this by setting phy_initialized flag to false in suspend callback Upstream Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Rahul T R <[email protected]>

RobertCNelson · 2022-11-15T15:00:22Z

Awesome @ravi-rahul testing right now!

ravi-rahul · 2022-11-15T15:03:54Z

Hi @RobertCNelson

This PR needs these device tree changes
beagleboard/BeagleBoard-DeviceTrees#64

Please test with device tree changes in above PR

RobertCNelson · 2022-11-15T15:22:13Z

ah so close... DisplayPorts works, but my RPI 7-inch isn't going beyond display init (no logo or console..) merging into staging branch to debug...

merge: beagleboard/linux#275 Signed-off-by: Robert Nelson <[email protected]>

RobertCNelson · 2022-11-15T15:38:12Z

Building artifacts.. https://git.beagleboard.org/RobertCNelson/ti-linux-kernel-dev/-/jobs/6712

RobertCNelson · 2022-11-15T15:54:18Z

test build out...

wget -O file.zip https://git.beagleboard.org/RobertCNelson/ti-linux-kernel-dev/-/jobs/6712/artifacts/download
unzip file.zip
sudo dpkg -i deploy/linux-image-5.10.145-ti-arm64-staging-r72.1_1xross_arm64.deb

RobertCNelson · 2022-11-15T16:02:13Z

On the panel system, @ravi-rahul what's the best way to see what it tried todo..

debian@BeagleBone:~/$ #panel
debian@BeagleBone:~/$ dmesg | grep dss
[   10.309796] [drm] Initialized tidss 1.0.0 20180215 for 4a00000.dss on minor 0
[   10.963273] tidss 4a00000.dss: [drm] fb0: tidssdrmfb frame buffer device

ravi-rahul · 2022-11-15T16:03:59Z

for me it's working, with test build artifacts

ravi-rahul · 2022-11-15T16:04:34Z

dmesg | grep -i RPi
dmesg | grep -i Rasp

ravi-rahul · 2022-11-15T16:08:48Z

sudo apt install libdrm-tests
modetest -M tidss

ravi-rahul · 2022-11-15T16:10:31Z

can you please share the log of modetest -M tidss on your setup

RobertCNelson · 2022-11-15T16:13:35Z

debian@BeagleBone:~/$ dmesg | grep -i Rasp
debian@BeagleBone:~/$ sudo beagle-version | grep UBOOT
UBOOT: Booted Device-Tree:[k3-j721e-beagleboneai64.dts]
UBOOT: Loaded Overlay:[BBAI64-DSI-RPi-7inch-panel.kernel]
debian@BeagleBone:~/$ dmesg | grep -i Rasp

BBAI64-DSI-RPi-7inch-panel is just a renamed version of yours..

RobertCNelson · 2022-11-15T16:14:10Z

debian@BeagleBone:~/$ modetest -M tidss
Encoders:
id      crtc    type    possible crtcs  possible clones
38      0       none    0x00000001      0x00000001
47      46      none    0x00000002      0x00000002

Connectors:
id      encoder status          name            size (mm)       modes   encoders
39      0       disconnected    DP-1            0x0             0       38
  props:
        1 EDID:
                flags: immutable blob
                blobs:

                value:
        2 DPMS:
                flags: enum
                enums: On=0 Standby=1 Suspend=2 Off=3
                value: 0
        5 link-status:
                flags: enum
                enums: Good=0 Bad=1
                value: 0
        6 non-desktop:
                flags: immutable range
                values: 0 1
                value: 0
        4 TILE:
                flags: immutable blob
                blobs:

                value:
48      47      connected       DSI-1           154x86          1       47
  modes:
        index name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot
  #0 800x480 60.00 800 848 880 960 480 483 490 496 28569 flags: nhsync, nvsync; type: preferred, driver
  props:
        1 EDID:
                flags: immutable blob
                blobs:

                value:
        2 DPMS:
                flags: enum
                enums: On=0 Standby=1 Suspend=2 Off=3
                value: 0
        5 link-status:
                flags: enum
                enums: Good=0 Bad=1
                value: 0
        6 non-desktop:
                flags: immutable range
                values: 0 1
                value: 0
        4 TILE:
                flags: immutable blob
                blobs:

                value:

CRTCs:
id      fb      pos     size
37      0       (0,0)   (0x0)
  #0  nan 0 0 0 0 0 0 0 0 0 flags: ; type: 
  props:
        24 VRR_ENABLED:
                flags: range
                values: 0 1
                value: 0
        27 CTM:
                flags: blob
                blobs:

                value:
        28 GAMMA_LUT:
                flags: blob
                blobs:

                value:
        29 GAMMA_LUT_SIZE:
                flags: immutable range
                values: 0 4294967295
                value: 256
46      61      (0,0)   (800x480)
  #0 800x480 60.00 800 848 880 960 480 483 490 496 28569 flags: nhsync, nvsync; type: preferred, driver
  props:
        24 VRR_ENABLED:
                flags: range
                values: 0 1
                value: 0
        27 CTM:
                flags: blob
                blobs:

                value:
        28 GAMMA_LUT:
                flags: blob
                blobs:

                value:
        29 GAMMA_LUT_SIZE:
                flags: immutable range
                values: 0 4294967295
                value: 256

Planes:
id      crtc    fb      CRTC x,y        x,y     gamma size      possible crtcs
31      0       0       0,0             0,0     0               0x00000003
  formats: AR12 AB12 RA12 RG16 BG16 AR15 AB15 AR24 AB24 RA24 BA24 RG24 BG24 AR30 AB30 XR12 XB12 RX12 AR15 AB15 XR24 XB24 RX24 BX24 XR30 XB30 YUYV UYVY NV12
  props:
        8 type:
                flags: immutable enum
                enums: Overlay=0 Primary=1 Cursor=2
                value: 1
        32 zpos:
                flags: range
                values: 0 3
                value: 0
        33 COLOR_ENCODING:
                flags: enum
                enums: ITU-R BT.601 YCbCr=0 ITU-R BT.709 YCbCr=1
                value: 0
        34 COLOR_RANGE:
                flags: enum
                enums: YCbCr limited range=0 YCbCr full range=1
                value: 0
        35 alpha:
                flags: range
                values: 0 65535
                value: 65535
        36 pixel blend mode:
                flags: enum
                enums: Pre-multiplied=0 Coverage=1
                value: 0
40      46      61      0,0             0,0     0               0x00000003
  formats: AR12 AB12 RA12 RG16 BG16 AR15 AB15 AR24 AB24 RA24 BA24 RG24 BG24 AR30 AB30 XR12 XB12 RX12 AR15 AB15 XR24 XB24 RX24 BX24 XR30 XB30 YUYV UYVY NV12
  props:
        8 type:
                flags: immutable enum
                enums: Overlay=0 Primary=1 Cursor=2
                value: 1
        41 zpos:
                flags: range
                values: 0 3
                value: 0
        42 COLOR_ENCODING:
                flags: enum
                enums: ITU-R BT.601 YCbCr=0 ITU-R BT.709 YCbCr=1
                value: 0
        43 COLOR_RANGE:
                flags: enum
                enums: YCbCr limited range=0 YCbCr full range=1
                value: 0
        44 alpha:
                flags: range
                values: 0 65535
                value: 65535
        45 pixel blend mode:
                flags: enum
                enums: Pre-multiplied=0 Coverage=1
                value: 0
49      0       0       0,0             0,0     0               0x00000003
  formats: AR12 AB12 RA12 RG16 BG16 AR15 AB15 AR24 AB24 RA24 BA24 RG24 BG24 AR30 AB30 XR12 XB12 RX12 AR15 AB15 XR24 XB24 RX24 BX24 XR30 XB30 YUYV UYVY NV12
  props:
        8 type:
                flags: immutable enum
                enums: Overlay=0 Primary=1 Cursor=2
                value: 0
        50 zpos:
                flags: range
                values: 0 3
                value: 0
        51 COLOR_ENCODING:
                flags: enum
                enums: ITU-R BT.601 YCbCr=0 ITU-R BT.709 YCbCr=1
                value: 0
        52 COLOR_RANGE:
                flags: enum
                enums: YCbCr limited range=0 YCbCr full range=1
                value: 0
        53 alpha:
                flags: range
                values: 0 65535
                value: 65535
        54 pixel blend mode:
                flags: enum
                enums: Pre-multiplied=0 Coverage=1
                value: 0
55      0       0       0,0             0,0     0               0x00000003
  formats: AR12 AB12 RA12 RG16 BG16 AR15 AB15 AR24 AB24 RA24 BA24 RG24 BG24 AR30 AB30 XR12 XB12 RX12 AR15 AB15 XR24 XB24 RX24 BX24 XR30 XB30 YUYV UYVY NV12
  props:
        8 type:
                flags: immutable enum
                enums: Overlay=0 Primary=1 Cursor=2
                value: 0
        56 zpos:
                flags: range
                values: 0 3
                value: 0
        57 COLOR_ENCODING:
                flags: enum
                enums: ITU-R BT.601 YCbCr=0 ITU-R BT.709 YCbCr=1
                value: 0
        58 COLOR_RANGE:
                flags: enum
                enums: YCbCr limited range=0 YCbCr full range=1
                value: 0
        59 alpha:
                flags: range
                values: 0 65535
                value: 65535
        60 pixel blend mode:
                flags: enum
                enums: Pre-multiplied=0 Coverage=1
                value: 0

Frame buffers:
id      size    pitch

ravi-rahul · 2022-11-15T16:21:57Z

dmesg | grep tc35

RobertCNelson · 2022-11-15T16:23:05Z

debian@BeagleBone:~/$ dmesg | grep tc35
[    3.004824] bridge_reg: supplied by tc358762-power

RobertCNelson · 2022-11-15T16:23:25Z

backlight is on, but i don't have any console prompt..

ravi-rahul · 2022-11-15T16:23:57Z

kmstest

ravi-rahul · 2022-11-15T16:24:10Z

can you run this command

RobertCNelson · 2022-11-15T16:26:34Z

looks like i need to build kmstest, which git source do you guys use..

ravi-rahul · 2022-11-15T16:26:46Z

can you please try below command and see if you get anything on the panel
modetest -M tidss -s 48@46:800x480

RobertCNelson · 2022-11-15T16:27:27Z

just stays blank..

debian@BeagleBone:~/$ modetest -M tidss -s 48@46:800x480
setting mode 800x480-60.00Hz on connectors 48, crtc 46

ravi-rahul · 2022-11-15T16:34:53Z

cat /proc/device-tree/bus@100000/dsi@48000000/compatible

RobertCNelson · 2022-11-15T16:37:56Z

debian@BeagleBone:~/$ cat /proc/device-tree/bus@100000/dsi@48000000/compatible
ti,j721e-dsi

ravi-rahul · 2022-11-15T16:44:48Z

root@BeagleBone:/home/debian# beagle-version | grep -i uboot
UBOOT: Booted Device-Tree:[k3-j721e-beagleboneai64.dts]
UBOOT: Loaded Overlay:[BBAI64-DSI-RPi-7inch-panel.kernel]
root@BeagleBone:/home/debian# uname -r
5.10.145-ti-arm64-staging-r72.1
root@BeagleBone:/home/debian# md5sum /boot/firmware/Image
46cd0c1979cf543df7ac2781a733db66 /boot/firmware/Image
root@BeagleBone:/home/debian# md5sum /boot/firmware/overlays/BBAI64-DSI-RPi-7inch-panel.dtbo
91b53360da6228e45fbcc7fc81b8e67b /boot/firmware/overlays/BBAI64-DSI-RPi-7inch-panel.dtbo
root@BeagleBone:/home/debian# md5sum /boot/firmware/k3-j721e-beagleboneai64.dtb
532fbe0c23b1cc2568671ca7879b0a78 /boot/firmware/k3-j721e-beagleboneai64.dtb
root@BeagleBone:/home/debian#

RobertCNelson · 2022-11-15T16:47:17Z

debian@BeagleBone:~/$ uname -r
5.10.145-ti-arm64-staging-r72.1
debian@BeagleBone:~/$ md5sum /boot/firmware/*
94e1c0a01c618dcea561041b8d8c167f  /boot/firmware/ID.txt
46cd0c1979cf543df7ac2781a733db66  /boot/firmware/Image
md5sum: /boot/firmware/extlinux: Is a directory
52244c7636ad3e9e00438a3b14993707  /boot/firmware/initrd.img
532fbe0c23b1cc2568671ca7879b0a78  /boot/firmware/k3-j721e-beagleboneai64.dtb

91b53360da6228e45fbcc7fc81b8e67b  /boot/firmware/overlays/BBAI64-DSI-RPi-7inch-panel.dtbo

grabing another card.. (with xfce installed).. this was just a test console image, that had always shown a prompt..

Regards,

RobertCNelson · 2022-11-15T16:49:11Z

RobertCNelson · 2022-11-15T16:50:19Z

usb on the back is powered, but this is how i have it setup, and how the screen looked prior to the patches..

ravi-rahul · 2022-11-15T17:17:50Z

setup looks correct, not sure what is the issue

RobertCNelson · 2022-11-15T17:20:40Z

so... with a fresh xfce image...

i don't know why basic console broke..

ravi-rahul · 2022-11-15T17:23:29Z

got it

RobertCNelson · 2022-11-15T17:24:10Z

i'll push it out.. not sure why console is broken, but x works..

ravi-rahul · 2022-11-15T17:25:01Z

Thanks !

fixes: beagleboard/linux#275 Signed-off-by: Robert Nelson <[email protected]>

ravi-rahul added 7 commits November 8, 2022 11:37

Revert "HACK: phy: cdns-dphy: DPHY wrapper related changes"

f4d97b7

This reverts commit feab9c3.

Revert "HACK: drm/bridge: cdns-dsi: Remove PM runtime calls"

a690ec0

This reverts commit 11b74d8.

Revert "drm/bridge: cdns-dsi: Set input for DPI0"

a8ca285

This reverts commit 33d13f2.

Revert "Revert "drm/bridge: cdns-dsi: Add support for J721E wrapper""

9219c6a

This reverts commit 1bb68a9.

Revert "Revert "phy: cdns-dphy: Add band config for dphy tx""

03a876b

This reverts commit 4d8f9a9.

Revert "Revert "phy: cdns-dphy: Add support for DPHY TX on J721e""

2a0f8a6

This reverts commit 575642d.

drm/bridge: cdns-dsi: Fix issue with phy init

54b48d5

Phy is not being initialized after suspend resume. Fix this by setting phy_initialized flag to false in suspend callback Upstream Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Rahul T R <[email protected]>

RobertCNelson added a commit to RobertCNelson/ti-linux-kernel-dev that referenced this pull request Nov 15, 2022

ti: display

4d29f8f

merge: beagleboard/linux#275 Signed-off-by: Robert Nelson <[email protected]>

RobertCNelson added a commit to RobertCNelson/ti-linux-kernel-dev that referenced this pull request Nov 15, 2022

merge ti drm rework

4ff4190

fixes: beagleboard/linux#275 Signed-off-by: Robert Nelson <[email protected]>

RobertCNelson closed this Nov 15, 2022

5.10 arm64 #275

5.10 arm64 #275

Uh oh!

Conversation

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RobertCNelson commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

RobertCNelson commented Nov 15, 2022

Uh oh!

ravi-rahul commented Nov 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RobertCNelson commented Nov 15, 2022 •

edited

Loading

RobertCNelson commented Nov 15, 2022 •

edited

Loading

RobertCNelson commented Nov 15, 2022 •

edited

Loading