fix: add configure-pages step to deploy workflow - #828
Merged
Conversation
The deploy workflow was missing the actions/configure-pages step, causing a 404 when actions/deploy-pages tried to create a deployment. This is needed to initialize the Pages API for Actions-based deploys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
actions/configure-pages@v4step to the GitHub Pages deploy workflow. This fixes the 404 error whenactions/deploy-pages@v4attempts to create a Pages deployment.The Astro redesign (#827) introduced a new GitHub Actions-based Pages deployment workflow, but omitted the
configure-pagesstep that initializes the Pages deployment API. Without it, the deployment endpoint doesn't exist and returns a 404.Test Steps
mainHttpError: Not Found)Checklist
npm run build— 329 pages)